From: "Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Morgan Willcock <morgan@ice9.digital>
Cc: 61850@debbugs.gnu.org
Subject: bug#61850: 29.0.60; Emacs 29 removes the ability to suppress ediff frames
Date: Mon, 27 Feb 2023 21:56:29 +0100 [thread overview]
Message-ID: <m1356q4yki.fsf@yahoo.es> (raw)
In-Reply-To: <86ilfnthjf.fsf@ice9.digital> (Morgan Willcock's message of "Mon, 27 Feb 2023 12:32:52 +0000")
Morgan Willcock <morgan@ice9.digital> writes:
> It no longer seems possible to prevent ediff creating additional frames.
> Previously this behaviour could be altered with:
>
> (advice-add 'ediff-window-display-p :override #'ignore)
>
> This no longer seems to work, I imagine because this functions is now an
> alias:
>
> (define-obsolete-function-alias 'ediff-window-display-p #'display-graphic-p "29.1")
>
> The problems caused by opening an additional frame do not necessarily
> correspond with the result of display-graphic-p. For example, when using
> EXWM a frame is a workspace and creating a new workspace is unlikely to
> be desirable or usable within an ediff session.
>
> If ediff-window-display-p is obsolete I think there needs to be a custom
> variable added to allow users to suppress the creation of new frames by
> ediff.
I think the supported way to make Ediff work in a single frame is the
following:
(setq ediff-window-setup-function 'ediff-setup-windows-plain)
next prev parent reply other threads:[~2023-02-27 20:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 12:32 bug#61850: 29.0.60; Emacs 29 removes the ability to suppress ediff frames Morgan Willcock
2023-02-27 20:02 ` Eli Zaretskii
2023-02-27 20:56 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-02-27 21:19 ` Morgan Willcock
2023-02-28 10:37 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1356q4yki.fsf@yahoo.es \
--to=bug-gnu-emacs@gnu.org \
--cc=61850@debbugs.gnu.org \
--cc=mardani29@yahoo.es \
--cc=morgan@ice9.digital \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).