From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 73881@debbugs.gnu.org
Subject: bug#73881: 31.0.50; Unexpected warnings about recursive occurrences of obsolete functions
Date: Sat, 19 Oct 2024 20:11:08 +0200 [thread overview]
Message-ID: <m134ksdkub.fsf@macbookpro.home> (raw)
In-Reply-To: <86wmi4jh54.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Oct 2024 17:34:31 +0300")
Hi,
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Sat, 19 Oct 2024 15:21:22 +0200
>> From: Eshel Yaron via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>>
>> 1. emacs -Q
>> 2. (require 'allout) or otherwise load allout.el
>> 3. Byte-compile allout.el with M-x byte-compile-file
>> 4. See warnings:
>>
>> --8<---------------cut here---------------start------------->8---
>> In allout-old-expose-topic:
>> allout.el:5092:29: Warning: ‘allout-old-expose-topic’ is an obsolete function
>> (as of 28.1); use ‘allout-expose-topic’ instead.
>> allout.el:5097:44: Warning: ‘allout-old-expose-topic’ is an obsolete function
>> (as of 28.1); use ‘allout-expose-topic’ instead.
>> allout.el:5106:8: Warning: ‘allout-old-expose-topic’ is an obsolete function
>> (as of 28.1); use ‘allout-expose-topic’ instead.
>> --8<---------------cut here---------------end--------------->8---
>>
>> These warnings are unhelpful since these are recursive calls within the
>> definition of the obsolete function itself. They need not be replaced
>> with another function as the warnings suggest. Ideally, recursive calls
>> to obsolete functions should not produce such warnings.
>
> From where I stand, this could be closed as wontfix, unless someone
> sees an easy fix. I don't see any harm from emitting these warnings
> in this scenario. The warnings are correct.
All right, FWIW I find them more distracting then helpful: if I'm
declaring a function as obsolete, that means it's going to stay around
for at least a short while, with its recursive calls, which I have no
interest in adapting. So these warnings do not tell me anything useful.
As for an easy fix, maybe something like this?
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 29e7882c851..edb8160a250 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -1533,6 +1533,7 @@ byte-compile-arglist-signature-string
(defun byte-compile-function-warn (f nargs def)
(when (and (get f 'byte-obsolete-info)
+ (not (eq f byte-compile-current-form)) ; Recursive call.
(not (memq f byte-compile-not-obsolete-funcs)))
(byte-compile-warn-obsolete f "function"))
next prev parent reply other threads:[~2024-10-19 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 13:21 bug#73881: 31.0.50; Unexpected warnings about recursive occurrences of obsolete functions Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-19 14:34 ` Eli Zaretskii
2024-10-19 18:11 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-10-19 18:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m134ksdkub.fsf@macbookpro.home \
--to=bug-gnu-emacs@gnu.org \
--cc=73881@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).