From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74511: 31.0.50; `dictionary-search-interface' overrides the user's customization of `dictionary-read-word-function' Date: Mon, 25 Nov 2024 22:27:57 +0100 Message-ID: References: <878qt8pik7.fsf@stebalien.com> <86sergihd5.fsf@gnu.org> <875xocpdxr.fsf@stebalien.com> <86plmjiko0.fsf@gnu.org> <878qt73yhg.fsf@stebalien.com> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12329"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 74511@debbugs.gnu.org To: Steven Allen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 25 22:29:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tFgds-00032d-T9 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Nov 2024 22:29:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tFgdk-0000Xh-WF; Mon, 25 Nov 2024 16:29:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFgdj-0000XI-DM for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2024 16:29:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tFgdj-000232-4Q for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2024 16:29:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=zHTfaPi46STIQ0KWD0V2R1RtRpfRLG/8Y/lk+/lybFk=; b=vA264ml0slSZQfGzcn1MObkoFDUQ1O/jh5S9xXsHBBrp00O321j2ZaJcGhoiut38n996k9HqBkIOoq5W5mOwgjNnp7XlpSwK9oBsYGAc469FqCoR0sJjuPI1P6GkaHyR0o35siEqawH/MkaqvXCptvWyfdBelIj6adhM7eqzAyYMerx93x+K7reszSQmihreiI4oBt+1miHxGyqL1dhpAD+ZaK48r/we7UB+J/ee0kGCNFJAcXcvD3LkcpIHHtJ29Ya5kQN1qG7Yq0sXPUafvrqWjBZeSF9QAjBeVDyYZSA4GhsM2GDOdwDiZdrweJF1Eh2NSOwp5/ZqcTZFZfPVMQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tFgdi-0005kz-JC for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2024 16:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Nov 2024 21:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74511 X-GNU-PR-Package: emacs Original-Received: via spool by 74511-submit@debbugs.gnu.org id=B74511.173257008422028 (code B ref 74511); Mon, 25 Nov 2024 21:29:02 +0000 Original-Received: (at 74511) by debbugs.gnu.org; 25 Nov 2024 21:28:04 +0000 Original-Received: from localhost ([127.0.0.1]:41861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFgcl-0005j6-Q4 for submit@debbugs.gnu.org; Mon, 25 Nov 2024 16:28:04 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:37306 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tFgcj-0005iR-1q for 74511@debbugs.gnu.org; Mon, 25 Nov 2024 16:28:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1732570080; bh=xwByXogHbY4aT2Pd7hAAtN05sWKNSyJwCWvs64N+OI0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=S6qJg8UrmUbvwOxI/8bqld/fiDpz3BPQYTPBicVNahYJ/4B35+KH2oFy5Y98W2yFX gcXKuGPI71arhuy5Wmz6T/MyEPDrCQDctDBZujTqQnhQxDbAHupqJ8OIx6IoOSakfm 1ywAOHzFeA70pMr/hdJJYfSRLikNDwBi2vasvX/DZkXRQXXIuL8FfqzyaXIP9DIgcJ 5XRGGAiH+bGKvp3+/vvYQSZ5B8SvNcqpc2L4vu9D9RGfn3v9QtMiwAdxLLh8qPMlVx B+G74ahAkTJGM8iR0ZwiE4cJMyzrkc3WlVihWzDkxsdD8WkjKmfxlpUl1PbtDWcSDM Yd3qZXygcR/RQ== In-Reply-To: <878qt73yhg.fsf@stebalien.com> (Steven Allen's message of "Mon, 25 Nov 2024 11:27:39 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295962 Archived-At: Steven Allen writes: > Eshel Yaron writes: > >> >> The patch below tries to do both: >> >> - it adds a few words to the docstring of dictionary-search-interface >> which explain that this option can only be meaningfully set after >> loading dictionary.el, and >> - it avoids clobbering existing settings for the other options during >> initialization. It still overrides existing settings for the other >> options if you set dictionary-search-interface after dictionary.el, >> because that's the intended behavior when customizing this option. >> >> WDYT? >> > > Is adding the following to `dictionary-search-interface' not sufficient? > > :initialize 'custom-initialize-changed > > That would apply the `dictionary-search-interface' setting if and only > if specified by the user while still alowing the user to, e.g., use the > customize interface. Ah yes, seems even better than my patch since it also makes it possible to set dictionary-search-interface before loading dictionary.el, thanks! Eli, does this seem OK for the release branch? diff --git a/lisp/net/dictionary.el b/lisp/net/dictionary.el index 58c2e9771ba..42fb8c57b40 100644 --- a/lisp/net/dictionary.el +++ b/lisp/net/dictionary.el @@ -317,6 +317,7 @@ dictionary-search-interface dictionary-read-dictionary-function) vals)) (set-default-toplevel-value symbol value)) + :initialize #'custom-initialize-changed :version "30.1") (defface dictionary-word-definition-face