From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#10062: 24.0.91; completions-first-difference Date: Tue, 17 Jan 2012 12:29:28 +0800 Message-ID: References: <8739do764s.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1326774675 22085 80.91.229.12 (17 Jan 2012 04:31:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 17 Jan 2012 04:31:15 +0000 (UTC) Cc: 10062@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 17 05:31:10 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rn0hS-0007B5-37 for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Jan 2012 05:31:10 +0100 Original-Received: from localhost ([::1]:45222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rn0hQ-0004Mj-Um for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jan 2012 23:31:08 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:56421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rn0hO-0004MT-0Y for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 23:31:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rn0hM-00063r-T8 for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 23:31:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rn0hM-00063n-RW for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 23:31:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Rn0iI-0004Te-D8 for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 23:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Jan 2012 04:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10062-submit@debbugs.gnu.org id=B10062.132677466217129 (code B ref 10062); Tue, 17 Jan 2012 04:32:02 +0000 Original-Received: (at 10062) by debbugs.gnu.org; 17 Jan 2012 04:31:02 +0000 Original-Received: from localhost ([127.0.0.1]:60955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rn0hJ-0004S7-IN for submit@debbugs.gnu.org; Mon, 16 Jan 2012 23:31:01 -0500 Original-Received: from mail-gy0-f172.google.com ([209.85.160.172]:44921) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rn0hG-0004Rz-5i for 10062@debbugs.gnu.org; Mon, 16 Jan 2012 23:30:59 -0500 Original-Received: by ghrr16 with SMTP id r16so528321ghr.3 for <10062@debbugs.gnu.org>; Mon, 16 Jan 2012 20:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=H964tFB7KN0HBUGxvAOCKrFb3K7/Zw4yTqh92Q8/JJ8=; b=ZW+JguFXBhPJCoEsGcvlNUNM9tSYLK0+amSHjRghpFSMt7yK7hJBL2S85tlvDv2ds0 7qyq8U6LI/TlqIvMUD14ro0VPw/+YTXLypWcaqyciGn1I2rQ1VkpFezyOUU86RUzAUVV fVVlCtpPwxjg8/We9DzvntQLFiTAynVzSG/2w= Original-Received: by 10.236.175.36 with SMTP id y24mr20519946yhl.64.1326774599736; Mon, 16 Jan 2012 20:29:59 -0800 (PST) Original-Received: from localhost ([117.128.173.211]) by mx.google.com with ESMTPS id e66sm34351373yhk.6.2012.01.16.20.29.55 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 Jan 2012 20:29:57 -0800 (PST) Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Mon, 16 Jan 2012 10:52:07 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.90 (Mac OS X 10.6.8) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55808 Archived-At: On 2012-01-16 23:52 +0800, Stefan Monnier wrote: > Rather than prevent faces from being added, I installed a patch which > strips them before insertion. > > > Stefan > > > --- lisp/minibuffer.el 2012-01-05 09:46:05 +0000 > +++ lisp/minibuffer.el 2012-01-16 15:41:07 +0000 > @@ -571,6 +571,10 @@ > (defun completion--replace (beg end newtext) > "Replace the buffer text between BEG and END with NEWTEXT. > Moves point to the end of the new text." > + ;; The properties on `newtext' include things like > + ;; completions-first-difference, which we don't want to include > + ;; upon insertion. > + (set-text-properties 0 (length newtext) nil newtext) > ;; Maybe this should be in subr.el. > ;; You'd think this is trivial to do, but details matter if you want > ;; to keep markers "at the right place" and be robust in the face of Thank you. This is a better fix. I think this bug can be closed. Leo