From: Leo <sdl.web@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 10062@debbugs.gnu.org
Subject: bug#10062: 24.0.91; completions-first-difference
Date: Tue, 17 Jan 2012 12:29:28 +0800 [thread overview]
Message-ID: <m11uqzc5p3.fsf@gmail.com> (raw)
In-Reply-To: <jwvk44r63z5.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 16 Jan 2012 10:52:07 -0500")
On 2012-01-16 23:52 +0800, Stefan Monnier wrote:
> Rather than prevent faces from being added, I installed a patch which
> strips them before insertion.
>
>
> Stefan
>
>
> --- lisp/minibuffer.el 2012-01-05 09:46:05 +0000
> +++ lisp/minibuffer.el 2012-01-16 15:41:07 +0000
> @@ -571,6 +571,10 @@
> (defun completion--replace (beg end newtext)
> "Replace the buffer text between BEG and END with NEWTEXT.
> Moves point to the end of the new text."
> + ;; The properties on `newtext' include things like
> + ;; completions-first-difference, which we don't want to include
> + ;; upon insertion.
> + (set-text-properties 0 (length newtext) nil newtext)
> ;; Maybe this should be in subr.el.
> ;; You'd think this is trivial to do, but details matter if you want
> ;; to keep markers "at the right place" and be robust in the face of
Thank you. This is a better fix. I think this bug can be closed.
Leo
next prev parent reply other threads:[~2012-01-17 4:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 9:45 bug#10062: 24.0.91; completions-first-difference Leo
2011-11-17 16:25 ` Leo
2011-11-18 1:47 ` Stefan Monnier
2012-01-16 9:18 ` Leo
2012-01-16 15:52 ` Stefan Monnier
2012-01-17 4:29 ` Leo [this message]
2012-01-17 14:07 ` Stefan Monnier
2011-12-01 4:20 ` Leo
2011-12-01 15:57 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m11uqzc5p3.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=10062@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).