From: Leo <sdl.web@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 11606@debbugs.gnu.org
Subject: bug#11606: 24.1; Get rid of buffer local hook variables in find-file.el
Date: Sun, 03 Jun 2012 10:07:28 +0800 [thread overview]
Message-ID: <m11ulxywpr.fsf@gmail.com> (raw)
In-Reply-To: <jwv8vg5fvie.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 02 Jun 2012 13:57:18 -0400")
On 2012-06-03 01:57 +0800, Stefan Monnier wrote:
> I like removing things, but could you expand on why you think we should
> remove these?
Not removing the hooks themselves but the buffer-local bits, i.e.
=== modified file 'lisp/find-file.el'
--- lisp/find-file.el 2012-05-04 05:14:14 +0000
+++ lisp/find-file.el 2012-06-03 02:06:57 +0000
@@ -284,11 +284,6 @@
;; No user definable variables beyond this point!
;; ==============================================
-(make-variable-buffer-local 'ff-pre-find-hook)
-(make-variable-buffer-local 'ff-pre-load-hook)
-(make-variable-buffer-local 'ff-post-load-hook)
-(make-variable-buffer-local 'ff-not-found-hook)
-(make-variable-buffer-local 'ff-file-created-hook)
(make-variable-buffer-local 'ff-case-fold-search)
(make-variable-buffer-local 'ff-always-in-other-window)
(make-variable-buffer-local 'ff-ignore-include)
next prev parent reply other threads:[~2012-06-03 2:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-02 4:44 bug#11606: 24.1; Get rid of buffer local hook variables in find-file.el Leo
2012-06-02 17:57 ` Stefan Monnier
2012-06-03 2:07 ` Leo [this message]
2012-06-03 3:18 ` Stefan Monnier
2012-06-03 4:05 ` Leo
2012-06-03 15:18 ` Stefan Monnier
2012-06-05 16:14 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m11ulxywpr.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=11606@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).