From: "Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: "Mattias Engdegård" <mattiase@acm.org>,
50777@debbugs.gnu.org,
"Stefan Monnier" <monnier@iro.umontreal.ca>
Subject: bug#50777: Dropping EIEIO from xref (for performance)
Date: Sat, 25 Sep 2021 16:07:40 +0200 [thread overview]
Message-ID: <m11r5czr2r.fsf@yahoo.es> (raw)
In-Reply-To: <ae803302-35d5-34ce-85e6-5921be60c914@yandex.ru> (Dmitry Gutov's message of "Fri, 24 Sep 2021 16:37:25 +0300")
Dmitry Gutov <dgutov@yandex.ru> writes:
> Resending with the intended recipients (except for the maintainers who
> are automatically subscribed anyway, to spare the inboxes).
>
> With the recent discussion about our Lisp overhead when the search
> returns many matches, I went a couple more rounds to try to identify
> the hotspots.
>
> My main benchmark for that is
>
> (benchmark 1 '(project-find-regexp "list"))
>
> in the Emacs repo. The 3 recent commits have reduced that time from 8s
> to 6.5s on my machine (under best conditions: warm disk cache and
> fresh Emacs session). The machine is pretty fast, so I figure we can
> multiply that timing by 2x, to imagine the average user experience.
Thanks for working on this. I checked the patch and I also see a
similar speedup in my system, working with a large monorepo.
>
> I'd like to push it soon, so users of Emacs 28 can enjoy the speedup.
>
> What do people think?
I agree with Lars, it's better not to rush this change. The change is
invasive and I think I was the only person to report a performance
problem so far in that part of the codebase. I guess it's better to
merge this just after the Emacs 28 branch is cut, so that users in a
stable version are not affected by any potential bug/interface
incompatibility not caught during pretest. Thanks.
next prev parent reply other threads:[~2021-09-25 14:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 13:28 bug#50777: Dropping EIEIO from xref (for performance) Dmitry Gutov
2021-09-24 13:35 ` Dmitry Gutov
2021-09-24 13:37 ` Dmitry Gutov
2021-09-24 14:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-24 15:32 ` Dmitry Gutov
2021-09-26 1:15 ` Dmitry Gutov
2021-09-26 8:51 ` Mattias Engdegård
2021-09-26 18:34 ` Dmitry Gutov
2021-09-24 15:12 ` Arthur Miller
2021-09-25 1:42 ` Lars Ingebrigtsen
2021-09-25 1:52 ` Dmitry Gutov
2021-09-25 14:07 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-09-26 2:16 ` Dmitry Gutov
2021-09-30 21:10 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m11r5czr2r.fsf@yahoo.es \
--to=bug-gnu-emacs@gnu.org \
--cc=50777@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=mardani29@yahoo.es \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).