From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66948: [PATCH] Add Completion Preview mode Date: Wed, 15 Nov 2023 20:02:32 +0100 Message-ID: References: <86a5rrcqd3.fsf@mail.linkov.net> <86zfzqeoix.fsf@mail.linkov.net> <86msvobtjm.fsf@mail.linkov.net> <86y1f7cs8l.fsf@mail.linkov.net> <83v8aaxdcy.fsf@gnu.org> <83msvlyczy.fsf@gnu.org> <83sf5cwu01.fsf@gnu.org> <83wmujqh89.fsf@gnu.org> <83bkbvq6k8.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40625"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: philipk@posteo.net, juri@linkov.net, dmitry@gutov.dev, joaotavora@gmail.com, 66948-done@debbugs.gnu.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 15 20:03:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3LAV-000AKx-Hf for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Nov 2023 20:03:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3LAG-000339-1q; Wed, 15 Nov 2023 14:03:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3LAF-00032o-2V for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 14:03:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3LAE-00029E-QT for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 14:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3LAD-0006PY-Pq for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 14:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Nov 2023 19:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66948 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66948-done@debbugs.gnu.org id=D66948.170007496024615 (code D ref 66948); Wed, 15 Nov 2023 19:03:01 +0000 Original-Received: (at 66948-done) by debbugs.gnu.org; 15 Nov 2023 19:02:40 +0000 Original-Received: from localhost ([127.0.0.1]:53810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3L9r-0006Ox-RO for submit@debbugs.gnu.org; Wed, 15 Nov 2023 14:02:40 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:46350 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3L9n-0006Ok-4h for 66948-done@debbugs.gnu.org; Wed, 15 Nov 2023 14:02:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1700074955; bh=ZAwkpXvSaMSHFdhBz4cfiO43m43ANvhRv/SipVOIYZU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=rw8+kXpRfzmlrusNxMy7XKR16jlVW7aTjzwFp0jtjKjJGbBQ/2RxZOXnQhZPDtOL2 7Ia5w0Dj2b0mc2EJIVBERPuUOBPh9roMzHciYPLsmORkIN7wnDvf84aE3oFvHYOlM8 wQp7a55YDEB6lqnxTgKJl9c3NCLRXoJ9Os4A2WS5KdnbvuspDzgrOMJsFADUju28S/ eDzxrxwXDNMKJT6YsIDC8S/9kF6RlmXdcb8RyQNbt0Twpghwj+YYx/kXgtmIwI0FaG YlR56ugZ9KeQdcf5yNkAkoKdVkZ2nk13U2rmQOPvzyR2jbRjOmeiQF/1smrOoKRdPa atGyYQusx1Xzg== In-Reply-To: <83bkbvq6k8.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Nov 2023 19:17:59 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274410 Archived-At: Eli Zaretskii writes: >> From: Eshel Yaron >> Cc: philipk@posteo.net, juri@linkov.net, dmitry@gutov.dev, >> stefankangas@gmail.com, 66948@debbugs.gnu.org, joaotavora@gmail.com >> Date: Wed, 15 Nov 2023 15:22:25 +0100 >> >> > How about some color (foreground or background)? >> >> Sure, I've added a fallback that uses `:weight bold` when that's >> supported but `:underline` isn't, and another ultimate fallback that >> uses a background color instead. Here's the updated patch (v6): > > Thanks, installed on master, and closing the bug. Great, thanks Eli, and thank you all for commenting and testing.