From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69809: 30.0.50; flymake: error in process sentinel Date: Wed, 17 Jul 2024 19:25:39 +0200 Message-ID: References: <867chv3mtf.fsf@gnu.org> <87le696o86.fsf@catern.com> <86v81bktv5.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30055"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: gerd.moellmann@gmail.com, Spencer Baugh , Eli Zaretskii , 69809@debbugs.gnu.org, sbaugh@catern.com To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 17 19:26:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sU8Pr-0007ag-8h for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Jul 2024 19:26:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sU8Pi-00068p-Tx; Wed, 17 Jul 2024 13:26:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sU8Pf-00067j-Qi for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2024 13:25:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sU8Pf-0005kr-FN for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2024 13:25:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sU8Pi-0007OG-Cx for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2024 13:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Jul 2024 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69809 X-GNU-PR-Package: emacs Original-Received: via spool by 69809-submit@debbugs.gnu.org id=B69809.172123715028389 (code B ref 69809); Wed, 17 Jul 2024 17:26:02 +0000 Original-Received: (at 69809) by debbugs.gnu.org; 17 Jul 2024 17:25:50 +0000 Original-Received: from localhost ([127.0.0.1]:36152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sU8PV-0007Np-K3 for submit@debbugs.gnu.org; Wed, 17 Jul 2024 13:25:50 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:60540 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sU8PR-0007Nf-KX for 69809@debbugs.gnu.org; Wed, 17 Jul 2024 13:25:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1721237141; bh=PudmczCq17cSjO+tMY3ghA4l0rdPyvxeB+2eQ218cwQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hqJDmEYt91TYt/wpGR3008Fb5RRZKn2+y+Pg986TV76n1N7Rpc+esLQBNUwgaUAzl KtWOmUzqgOKkcY/xFmFWyr0DpG+XP9kca8124T0KLTTbdc+wE3HxhsKU12TLuD1IV2 GDJJuwJBV6GduRYBkHq/H8Qgr15HiFNsSNMXX0Qx6dk6oBgEIoj5+scGpkSFYnMoky Jms6Fp5j2wPsncH4AWr4Ev6XePA4j3otY9vHxTwIYPbsDk5qmujBlJag5zSYoLRPtw Un+TtfnNp4zbOneVHfFjQ6fGaOW/he2EF5EJ6Kcz6tGi9KA1Xm9AVmBSutSUX0L33n 5gyoxjapkcuqw== In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 17 Jul 2024 14:44:11 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288930 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > On Wed, Jul 17, 2024 at 2:08=E2=80=AFPM Eshel Yaron w= rote: >> >> Hi Jo=C3=A3o, >> >> Jo=C3=A3o T=C3=A1vora writes: >> >> > On Wed, Jul 17, 2024 at 9:20=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: >> >> >> >> On Wed, Jul 17, 2024 at 7:12=E2=80=AFAM Eshel Yaron wrote: >> >> >> >> > > Yes, this seems good for emacs-30. Thanks Eshel! >> >> > Great, thanks. Since this is a change in eglot.el, let me also ask= Jo=C3=A3o >> >> > before installing: Jo=C3=A3o, any objections to the change above? >> >> >> >> I'd like to understand what problem it is solving. >> > >> > I've read a bit of the thread. There seems to be an error involved, >> > but I didn't see a backtrace for this error. Can someone produce it? >> >> Sure, here's one (also see the recipe I posted upthread): > > Thanks. Is the backtrace below what's unequivocally (or close) > produced by that recipe? Yes, that's what I see. > Anyway, can you try this patch? That seems to work too :) > diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el > index e72f25fd0cd..74db9b56dd9 100644 > --- a/lisp/progmodes/flymake.el > +++ b/lisp/progmodes/flymake.el > @@ -991,7 +991,7 @@ flymake--highlight-line > ;; third-party compatibility. > (define-obsolete-function-alias 'flymake-display-warning 'message-box "2= 6.1") > > -(defvar-local flymake--state nil > +(defvar-local flymake--state (make-hash-table) > "State of a buffer's multiple Flymake backends. > The keys to this hash table are functions as found in > `flymake-diagnostic-functions'. The values are structures > @@ -1396,7 +1396,6 @@ flymake-mode > ;; reinitializing `flymake--state' in the next line. > ;; See https://github.com/joaotavora/eglot/issues/223. > (mapc #'flymake--delete-overlay (flymake--really-all-overlays)) > - (setq flymake--state (make-hash-table)) > (setq flymake--recent-changes nil) > > (when flymake-start-on-flymake-mode (flymake-start t))