From: Austin Frank <austin.frank@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: bug#831: 23.0.60; error in nsfonts.m
Date: Sat, 30 Aug 2008 13:32:39 -0400 [thread overview]
Message-ID: <m0fxomz9vs.fsf@gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 340 bytes --]
I'm trying to build emacs from a current CVS checkout on OSX 10.4.11
with the configure option --with-ns.
Build fails because of error in nsfonts.m. That file references a
variable called gidx, which is not defined in the relevant structure.
The attached patch changes all instances of gidx to x, and allows emacs
to build on my system.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: gidx.patch --]
[-- Type: text/x-patch, Size: 1552 bytes --]
diff --git a/src/nsfont.m b/src/nsfont.m
index f49cd0f..10b1c90 100644
--- a/src/nsfont.m
+++ b/src/nsfont.m
@@ -904,14 +904,14 @@ nsfont_draw (struct glyph_string *s, int from, int to, int x, int y,
int hi, lo;
char isComposite = 0; /* s->first_glyph->type == COMPOSITE_GLYPH; */
/* FIXME: composition: no vertical displacement is considered. */
- t+= s->gidx; /* advance into composition */
- for (i =0; i<s->nchars - s->gidx; i++, t++)
+ t+= s->x; /* advance into composition */
+ for (i =0; i<s->nchars - s->x; i++, t++)
{
hi = (*t & 0xFF00) >> 8;
lo = *t & 0x00FF;
if (isComposite)
{
- cwidth = s->cmp->offsets[s->gidx++ * 2] - twidth;
+ cwidth = s->cmp->offsets[s->x++ * 2] - twidth;
}
else
{
@@ -1094,13 +1094,13 @@ nsfont_draw (struct glyph_string *s, int from, int to, int x, int y,
[col set];
CGContextSetTextPosition (gcontext, r.origin.x, r.origin.y);
- CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->gidx,
+ CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->x,
advances, len);
if (face->overstrike)
{
CGContextSetTextPosition (gcontext, r.origin.x+0.5, r.origin.y);
- CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->gidx,
+ CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->x,
advances, len);
}
[-- Attachment #1.3: Type: text/plain, Size: 568 bytes --]
In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, X toolkit)
of 2008-08-29 on malibu.local
Important settings:
value of $LC_ALL: en_US.UTF-8
value of $LC_COLLATE: nil
value of $LC_CTYPE: en_US.UTF-8
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: nil
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default-enable-multibyte-characters: t
--
Austin Frank
http://aufrank.net
GPG Public Key (D7398C2F): http://aufrank.net/personal.asc
[-- Attachment #2: Type: application/pgp-signature, Size: 193 bytes --]
next prev reply other threads:[~2008-08-30 17:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <66A91CA5-0AFE-42F4-B27F-3F24BE8626A6@gmail.com>
2008-08-29 18:50 ` bug#823: 23.0.60; uninitialised variable gidx in nsfont.m Peter Dyballa
2008-10-03 18:10 ` bug#823: marked as done (23.0.60; uninitialised variable gidx in nsfont.m) Emacs bug Tracking System
2008-08-29 20:23 ` bug#827: 23.0.60; bootstrap error: nsfont.m Clifford Wulfman
2008-10-03 18:10 ` bug#827: marked as done (23.0.60; bootstrap error: nsfont.m) Emacs bug Tracking System
2008-08-30 17:32 ` Austin Frank [this message]
2008-08-30 19:59 ` bug#831: 23.0.60; error in nsfonts.m Glenn Morris
2008-08-31 17:49 ` Austin Frank
[not found] ` <mailman.18065.1220206065.18990.bug-gnu-emacs@gnu.org>
2008-09-07 11:26 ` Ted Zlatanov
2008-09-07 20:37 ` bug#381: " Glenn Morris
2008-09-08 10:29 ` Ted Zlatanov
2008-09-08 21:17 ` Glenn Morris
2008-10-03 18:10 ` bug#831: marked as done (23.0.60; error in nsfonts.m) Emacs bug Tracking System
2008-08-30 18:00 ` bug#832: Compiling Emacs.app fails this afternoon Gilbert Harman
2008-09-01 11:30 ` bug#852: [Emacs.app dev]: " Robert Casties
2008-09-02 14:55 ` bug#862: " Dan Villiom Podlaski Christiansen
2008-09-02 17:02 ` bug#866: " Cezar Halmagean
2008-10-03 18:10 ` bug#866: marked as done ([Emacs.app dev]: Compiling Emacs.app fails this afternoon.) Emacs bug Tracking System
2008-10-03 18:10 ` bug#862: " Emacs bug Tracking System
2008-10-03 18:10 ` bug#852: " Emacs bug Tracking System
2008-09-04 6:23 ` bug#832: Compiling Emacs.app fails this afternoon. [PATCH] Daniel Koning
2008-10-03 18:10 ` bug#832: marked as done (Compiling Emacs.app fails this afternoon.) Emacs bug Tracking System
2008-08-30 22:14 ` bug#833: 23.0.60; make bootstrap broken in CVS head Clifford Wulfman
2008-10-03 18:10 ` bug#833: marked as done (23.0.60; make bootstrap broken in CVS head) Emacs bug Tracking System
2008-09-01 20:39 ` bug#855: Build errors Eddie Hillenbrand
2008-10-03 18:10 ` bug#855: marked as done (Build errors ) Emacs bug Tracking System
2008-09-04 15:04 ` bug#887: 23.0.60; glyph_string->gidx removal causes HEAD compilation failure under OS X Sudish Joseph
2008-10-03 18:10 ` bug#887: marked as done (23.0.60; glyph_string->gidx removal causes HEAD compilation failure under OS X) Emacs bug Tracking System
2008-09-06 14:14 ` bug#903: CVS HEAD won't build --with-ns on OSX 10.5 (fails src/nsfont.m) Randal L. Schwartz
2008-10-03 18:10 ` bug#903: marked as done (CVS HEAD won't build --with-ns on OSX 10.5 (fails src/nsfont.m)) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m0fxomz9vs.fsf@gmail.com \
--to=austin.frank@gmail.com \
--cc=831@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).