* bug#28793: 26.0.90; Compile error with Emacs 26 on macOS 10.13
@ 2017-10-12 6:19 George Plymale II
2017-10-12 10:22 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: George Plymale II @ 2017-10-12 6:19 UTC (permalink / raw)
To: 28793
So I tried compiling Emacs 26 on macOS 10.13. I configured with
`./configure' and everything went fine. However, when I ran `make', the
following error appeared:
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C lib all
CC acl_entries.o
CC explicit_bzero.o
CC fpending.o
CC fstatat.o
CC getopt.o
CC getopt1.o
CC lstat.o
CC memrchr.o
CC mktime.o
CC open.o
open.c:75:27: error: unknown type name 'PROMOTED_MODE_T'
mode = va_arg (arg, PROMOTED_MODE_T);
^
1 error generated.
make[1]: *** [open.o] Error 1
make: *** [lib] Error 2
Upon inspecting this error, I see the following comment above the
offending code:
/* We have to use PROMOTED_MODE_T instead of mode_t, otherwise GCC 4
creates crashing code when 'mode_t' is smaller than 'int'. */
I also see the following output regarding `open.c' when I compile with
`make CFLAGS="-v"':
...
CC open.o
Apple LLVM version 9.0.0 (clang-900.0.37)
Target: x86_64-apple-darwin17.0.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang" -cc1 -triple x86_64-apple-macosx10.13.0 -Wdeprecated-objc-isa-usage -Werror=deprecated-objc-isa-usage -emit-obj -mrelax-all -disable-free -disable-llvm-verifier -discard-value-names -main-file-name open.c -mrelocation-model pic -pic-level 2 -mthread-model posix -mdisable-fp-elim -fno-strict-return -masm-verbose -munwind-tables -target-cpu penryn -target-linker-version 302.3 -v -dwarf-column-info -debugger-tuning=lldb -coverage-notes-file /Users/my_username/path/to/emacs/lib/open.gcno -resource-dir /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/9.0.0 -dependency-file deps/open.d -MT open.o -MP -I . -I ../src -I . -I ./../src -Wno-switch -Wno-pointer-sign -Wno-string-plus-int -Wno-unknown-attributes -Wno-initializer-overrides -Wno-tautological-compare -Wno-tautological-constant-out-of-range-compare -fdebug-compilation-dir /Users/my_username/path/to/emacs/lib -ferror-limit 19 -fmessage-length 119 -stack-protector 1 -fblocks -fobjc-runtime=macosx-10.13.0 -fencode-extended-block-signature -fmax-type-align=16 -fdiagnostics-show-option -fcolor-diagnostics -o open.o -x c open.c
clang -cc1 version 9.0.0 (clang-900.0.37) default target x86_64-apple-darwin17.0.0
ignoring duplicate directory "."
ignoring duplicate directory "../src"
#include "..." search starts here:
#include <...> search starts here:
.
../src
/usr/local/include
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/9.0.0/include
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include
/usr/include
/System/Library/Frameworks (framework directory)
/Library/Frameworks (framework directory)
End of search list.
open.c:75:27: error: unknown type name 'PROMOTED_MODE_T'
mode = va_arg (arg, PROMOTED_MODE_T);
^
1 error generated.
make[1]: *** [open.o] Error 1
make: *** [lib] Error 2
Anyone know how to fix this error? I'd hate to run into something like
this in a non-release-candidate release...
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#28793: 26.0.90; Compile error with Emacs 26 on macOS 10.13
2017-10-12 6:19 bug#28793: 26.0.90; Compile error with Emacs 26 on macOS 10.13 George Plymale II
@ 2017-10-12 10:22 ` Eli Zaretskii
2017-10-12 10:43 ` George Plymale II
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2017-10-12 10:22 UTC (permalink / raw)
To: George Plymale II; +Cc: 28793
> From: George Plymale II <georgie@southernohio.net>
> Date: Thu, 12 Oct 2017 02:19:19 -0400
>
> open.c:75:27: error: unknown type name 'PROMOTED_MODE_T'
> mode = va_arg (arg, PROMOTED_MODE_T);
> ^
> 1 error generated.
> make[1]: *** [open.o] Error 1
PROMOTED_MODE_T is defined in src/config.h, please see what happened
there. On my system, I see this in config.h:
/* Define to the type that is the result of default argument promotions of
type mode_t. */
#define PROMOTED_MODE_T int
On another system I see this:
/* Define to the type that is the result of default argument promotions of
type mode_t. */
#define PROMOTED_MODE_T mode_t
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#28793: 26.0.90; Compile error with Emacs 26 on macOS 10.13
2017-10-12 10:22 ` Eli Zaretskii
@ 2017-10-12 10:43 ` George Plymale II
2017-10-12 12:01 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: George Plymale II @ 2017-10-12 10:43 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: georgie, 28793
Thanks for the tip. I see no results in my src/config.h when I run `M-x
occur PROMOTED_MODE_T'
Did I miss something in the configure stage? I'm sure that this can't be
right and there must be something odd on my end.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#28793: 26.0.90; Compile error with Emacs 26 on macOS 10.13
2017-10-12 10:43 ` George Plymale II
@ 2017-10-12 12:01 ` Eli Zaretskii
2017-10-13 0:52 ` George Plymale II
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2017-10-12 12:01 UTC (permalink / raw)
To: George Plymale II; +Cc: 28793
> From: George Plymale II <georgie@southernohio.net>
> Cc: georgie@southernohio.net, 28793@debbugs.gnu.org
> Date: Thu, 12 Oct 2017 06:43:23 -0400
>
> Thanks for the tip. I see no results in my src/config.h when I run `M-x
> occur PROMOTED_MODE_T'
That's strange. src /config.in includes this:
/* Define to the type that is the result of default argument promotions of
type mode_t. */
#undef PROMOTED_MODE_T
Do you see it? (Please don't rely on "M-x occur", it's possible that
it fails to find the string for some unrelated reason. Please search
manually around line 1470.)
> Did I miss something in the configure stage? I'm sure that this can't be
> right and there must be something odd on my end.
Does config.log include any references to "promoted mode_t"?
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#28793: 26.0.90; Compile error with Emacs 26 on macOS 10.13
2017-10-12 12:01 ` Eli Zaretskii
@ 2017-10-13 0:52 ` George Plymale II
2017-10-13 6:49 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: George Plymale II @ 2017-10-13 0:52 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: athird, georgie, 28793
Ok, so it turns out that I just needed to do `make distclean' and re-run
`./autogen.sh'. I guess my `src/config.in' was out of date and so that
is what caused the issue. Everything is fine now!
Thanks a lot for the advice; feel free to close this ticket.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#28793: 26.0.90; Compile error with Emacs 26 on macOS 10.13
2017-10-13 0:52 ` George Plymale II
@ 2017-10-13 6:49 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2017-10-13 6:49 UTC (permalink / raw)
To: George Plymale II; +Cc: athird, 28793-done
> From: George Plymale II <georgie@southernohio.net>
> Cc: georgie@southernohio.net, 28793@debbugs.gnu.org, athird@googlemail.com
> Date: Thu, 12 Oct 2017 20:52:25 -0400
>
> Ok, so it turns out that I just needed to do `make distclean' and re-run
> `./autogen.sh'. I guess my `src/config.in' was out of date and so that
> is what caused the issue. Everything is fine now!
>
> Thanks a lot for the advice; feel free to close this ticket.
Thanks, done.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-13 6:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-12 6:19 bug#28793: 26.0.90; Compile error with Emacs 26 on macOS 10.13 George Plymale II
2017-10-12 10:22 ` Eli Zaretskii
2017-10-12 10:43 ` George Plymale II
2017-10-12 12:01 ` Eli Zaretskii
2017-10-13 0:52 ` George Plymale II
2017-10-13 6:49 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).