bug#6121: 24.0.50; setting-constant enable-multibyte-characters

bug#6121: 24.0.50; setting-constant enable-multibyte-characters

[Stefan Reich=f6r]

I found a problem with gnus from a recent emacs:

Sadly it depends on a confidential email.
However, I hope that the backtrace below will be sufficient to fix the problem:

,----
| Debugger entered--Lisp error: (setting-constant enable-multibyte-characters)
|   set-default(enable-multibyte-characters nil)
|   message-forward-make-body-mml(#<buffer  *Original Article*>)
|   message-forward-make-body(#<buffer  *Original Article*> nil)
|   message-forward(nil)
|   gnus-summary-mail-forward(nil)
|   call-interactively(gnus-summary-mail-forward nil nil)
`----



In GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.16.1)
 of 2010-04-29 on pchagakli
Windowing system distributor `The X.Org Foundation', version 11.0.10600000
configured using `configure  '--prefix=/home/srei/prg/stow/emacs''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Debugger

Minor modes in effect:
  desktop-save-mode: t
  icomplete-mode: t
  global-cwarn-mode: t
  diff-auto-refine-mode: t
  global-auto-revert-mode: t
  shell-dirtrack-mode: t
  recentf-mode: t
  cua-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
n n <C-f1> M-x g n u s <return> y M-x t o g g l e - 
d e <tab> e <tab> <return> <f8> <down> <down> <down> 
<down> <down> <return> M-u <up> C-c C-f C-x h M-w M-x 
e m a c s - r e <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
r e p o r t <tab> <return>

Recent messages:
debug-on-error is now t [2 times]
Retrieving newsgroup: nnml:mail.msc-ge...
Fetching headers for nnml:mail.msc-ge...done
Scoring...done
Generating summary...done
Parsing BBDB... (frobnicating...done) [2 times]
Registry: article <m0fx25wm4i.fsf@totally-fudged-out-message-id> spooled to drafts
Entering debugger...
Mark set [2 times]
Scanning for dabbrevs...100%

Load-path shadows:
/home/srei/site-lisp/cedet/semantic/wisent/wisent-javascript hides /home/srei/site-lisp/cedet/contrib/wisent-javascript
/home/srei/site-lisp/cedet/semantic/wisent/wisent-javascript-jv-wy hides /home/srei/site-lisp/cedet/contrib/wisent-javascript-jv-wy
/home/srei/site-lisp/cedet/contrib/semanticdb-javascript hides /home/srei/site-lisp/cedet/semantic/semanticdb-javascript
/home/srei/site-lisp/w3m/w3m-session hides /home/srei/site-lisp/w3m-session
/home/srei/site-lisp/cedet/common/ezimage hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/ezimage
/home/srei/site-lisp/htmlfontify hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/htmlfontify
/home/srei/site-lisp/hfy-cmap hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/hfy-cmap
/home/srei/site-lisp/cedet/speedbar/sb-image hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/sb-image
/home/srei/site-lisp/cedet/speedbar/speedbar hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/speedbar
/home/srei/site-lisp/cedet/speedbar/dframe hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/dframe
/home/srei/site-lisp/flim/md4 hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/md4
/home/srei/site-lisp/css-mode hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/textmodes/css-mode
/home/srei/site-lisp/verilog-mode hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/progmodes/verilog-mode
/home/srei/site-lisp/org hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/org/org
/home/srei/site-lisp/flim/hmac-md5 hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/net/hmac-md5
/home/srei/site-lisp/flim/sasl-cram hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/net/sasl-cram
/home/srei/site-lisp/newsticker hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/net/newsticker
/home/srei/site-lisp/flim/ntlm hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/net/ntlm
/home/srei/site-lisp/flim/sasl hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/net/sasl
/home/srei/site-lisp/flim/hmac-def hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/net/hmac-def
/home/srei/site-lisp/flim/sasl-ntlm hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/net/sasl-ntlm
/home/srei/site-lisp/flim/sasl-digest hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/net/sasl-digest
/home/srei/site-lisp/cedet/eieio/eieio-opt hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/emacs-lisp/eieio-opt
/home/srei/site-lisp/cedet/eieio/eieio-custom hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/emacs-lisp/eieio-custom
/home/srei/site-lisp/cedet/eieio/eieio-datadebug hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/emacs-lisp/eieio-datadebug
/home/srei/site-lisp/cedet/eieio/eieio-base hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/emacs-lisp/eieio-base
/home/srei/site-lisp/cedet/eieio/eieio-speedbar hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/emacs-lisp/eieio-speedbar
/home/srei/site-lisp/cedet/eieio/eieio-comp hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/emacs-lisp/eieio-comp
/home/srei/site-lisp/cedet/eieio/chart hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/emacs-lisp/chart
/home/srei/site-lisp/cedet/eieio/eieio hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/emacs-lisp/eieio
/home/srei/site-lisp/cedet/common/mode-local hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/cedet/mode-local
/home/srei/site-lisp/cedet/common/data-debug hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/cedet/data-debug
/home/srei/site-lisp/cedet/common/cedet-global hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/cedet/cedet-global
/home/srei/site-lisp/cedet/common/cedet-cscope hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/cedet/cedet-cscope
/home/srei/site-lisp/cedet/semantic/semantic hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/cedet/semantic
/home/srei/site-lisp/cedet/common/cedet hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/cedet/cedet
/home/srei/site-lisp/cedet/ede/ede hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/cedet/ede
/home/srei/site-lisp/cedet/common/inversion hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/cedet/inversion
/home/srei/site-lisp/cedet/common/cedet-files hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/cedet/cedet-files
/home/srei/site-lisp/cedet/common/pulse hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/cedet/pulse
/home/srei/site-lisp/cedet/common/cedet-idutils hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/cedet/cedet-idutils
/home/srei/site-lisp/cedet/srecode/srecode hides /home/srei/prg/stow/emacs/share/emacs/24.0.50/lisp/cedet/srecode

Features:
(shadow dabbrev emacsbug help-mode cedet-edebug debug bbdb-gui gnus-cite
smiley gnus-async gnus-bcklg qp gnus-ml disp-table gnus-topic parse-time
nnfolder pop3 nnml nndraft nnmh bbdb-gnus bbdb-snarf mail-extr
gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-cache
sigbegone spam spam-stat gnus-uu yenc gnus-namazu gnus-alias
gnus-registry netrc nntp tex-buf vhdl-mode mmm-mode mmm-univ mmm-class
mmm-region mmm-utils reftex-vcr reftex-dcr reftex-auc noutline outline
latex tex-style semantic-decorate-mode semantic-decorate pulse
semanticdb-find semanticdb-ref vc-hg xhg-dvc vc-svn vc-arch gnus-dired
ede-dired python-live-update xte ger-userdata moinmoin-mode linkd
semanticdb-file semantic-edit semantic-el semantic-bovine bovine-debug
semantic-debug planner-registry planner-deadline planner-trunk
planner-psvn xhg xhg-annotate xhg-mq xhg-log bzr-submit bzr dvc-annotate
bzr-gnus xgit-gnus xhg-gnus midnight dar deutsch-alt-neu ion3 grmon view
holidays hol-loaddefs tla smerge-mode dvc-state dvc-config dvc-diff
dvc-fileinfo diff tla-gnus dvc-gnus dvc-cmenu dvc-about dvc-version
dvc-revlist ede-simple cedet-files ede-linux ede-emacs ede-cpp-root
desktop filecache woof progr-align pwsafe remind-mode quick-task x-dict
diminish babel url-handlers mm-url url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-util url-parse url-vars w3m-wget
webjump browse-url mkback mmm-auto mmm-vars mmm-compat tmmofl
mouse-embrace xwindow-ring saveplace live-mode defaultcontent toc align
boxes longlines ireplace findr findstr igrep ange-ftp grep tempbuf
keep-buffers minibuffer-complete-cycle icomplete browse-kill-ring
generic-dl generic-menu misc newcomment planner-diary
planner-tasks-overview planner-accomplishments planner-gnus gnus-msg
gnus-art mm-uu mml2015 epg-config mm-view smime dig mailcap gnus-sum
nnoo gnus-group time-date gnus-undo nnmail mail-source gnus-start
gnus-spec gnus-int gnus-range gnus-win gnus gnus-ems nnheader
planner-multi crm planner-id planner-bbdb planner sort muse-latex
muse-html muse-xml-common muse-wiki muse-colors pcomplete cus-edit
cus-start cus-load muse-publish muse-project muse-protocols muse-regexps
muse muse-nested-tags muse-mode message sendmail rfc822 mml mml-sec
mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils gmm-utils mailheader
bbdb-autoloads bbdb-query bbdb-print bbdb-com mailabbrev bbdb timezone
boxquote rect timeclock find-recursive bubble-buffer ibuffer
wisent-python wisent-python-wy semantic-wisent wisent ecb ecb-analyse
ecb-compatibility ecb-winman-support ecb-autogen autoload ecb-tod
ecb-cycle ecb-eshell ecb-help ecb-jde ecb-method-browser
ecb-file-browser ecb-layout ecb-create-layout ecb-compilation
ecb-speedbar ecb-common-browser ecb-semantic-wrapper ecb-navigate
ecb-mode-line ecb-face tree-buffer avoid ecb-upgrade ecb-util thingatpt
silentcomp senator which-func semantic-imenu semantic-sb imenu
semantic-mru-bookmark semanticdb-mode semantic-idle eassist cedet
speedbar-load speedbar-loaddefs sb-info ede-load ede-loaddefs
ede-speedbar ede-files ede bzr-core tla-core tla-autoconf tla-defs
dvc-log vc vc-dispatcher dvc-unified dvc-tips ffap ediff xdarcs-core
xgit-core xhg-core xmtn-minimal eieio-speedbar eieio-custom ede-source
srecode-load srecode srecode-loaddefs semantic-load semantic-ia-sb
semantic-analyze semantic-scope semantic-analyze-fcn semantic-sort
semanticdb-el semanticdb-search semantic-find semanticdb eieio-base
semantic-ctxt semantic-format semantic-util-modes semantic-util semantic
semantic-lex semantic-tag working fame semantic-fw semantic-loaddefs
mode-local find-func eieio-load eieio-loaddefs cedet-load cedet-compat
cedet-loaddefs eieio inversion sb-rmail sb-html sb-texinfo speedbar
sb-image ezimage dframe escreen find-library read-library appt diary-lib
diary-loaddefs esh-groups eshell esh-var esh-io esh-cmd esh-ext esh-proc
esh-arg eldoc esh-mode esh-util esh-module esh-toggle
python-exception-walker pydoc ipython executable xsteve-python
python-mode info-look info ansi-color compile warnings vsim-nav cwarn
cc-mode cc-fonts cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars
cc-defs skeleton reftex reftex-vars font-latex tex tex-site screen-lines
hideshow printing ps-print ps-def lpr msb mouse-copy paren stig-paren
reporter xsteve-functions cal-iso cal-menu calendar cal-loaddefs
bookmark dvc-autoloads dvc-core dvc-lisp dvc-buffers dvc-ui dvc-register
dvc-utils dvc-emacs ewoc dvc-defs dvc-site psvn byte-opt bytecomp
byte-compile derived edmacro kmacro cl cl-19 log-edit pcvs-util add-log
diff-mode pp elp ediff-merg ediff-diff ediff-wind ediff-mult ediff-help
ediff-init ediff-util uniquify autorevert ehelp electric tramp-imap
assoc tramp-gw tramp-fish tramp-smb tramp-cache tramp-ftp tramp-cmds
tramp auth-source gnus-util advice help-fns advice-preload shell
password-cache format-spec tramp-compat trampver recentf tree-widget
wid-edit easymenu generic-x server ls-lisp wdired dired-x dired-aux
dired ido hippie-exp comint regexp-opt ring cua-base easy-mmode hi-lock
tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar
dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow
timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu
font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan
thai tai-viet lao korean japanese hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces
cus-face files text-properties overlay md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote
make-network-process dynamic-setting font-render-setting gtk x-toolkit x
multi-tty emacs)

bug#6121: 24.0.50; setting-constant enable-multibyte-characters

[Glenn Morris]

2010-05-10  Katsumi Yamaoka  <yamaoka at jpl.org>

* mm-util.el (mm-with-unibyte-current-buffer): Redefine it so as not
to bind the default value of enable-multibyte-characters to nil.

bug#6121: 24.0.50; setting-constant enable-multibyte-characters

[Jim Meyering]

FYI, I've encountered exactly the same problem as described here:

  http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6121

It happens nearly any time I try to forward a message from gnus.
I am using the latest built from git.

BTW, I noticed that today it fails to build:

  Loading bindings (source)...
  Loading /mirror/d/emacs/lisp/files.el (source)...
  Symbol's function definition is void: define-minor-mode
  make[2]: *** [bootstrap-emacs] Error 255
  make[2]: Leaving directory `/tmp/jt-ltHmbB/emacs/src'
  make[1]: *** [src] Error 2
  make[1]: Leaving directory `/tmp/jt-ltHmbB/emacs'
  make: *** [bootstrap] Error 2

Re: bug#6121: 24.0.50; setting-constant enable-multibyte-characters

[Jim Meyering]

Jim Meyering wrote:
> FYI, I've encountered exactly the same problem as described here:
>
>   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6121
>
> It happens nearly any time I try to forward a message from gnus.
> I am using the latest built from git.
>
> BTW, I noticed that today it fails to build:
>
>   Loading bindings (source)...
>   Loading /mirror/d/emacs/lisp/files.el (source)...
>   Symbol's function definition is void: define-minor-mode
>   make[2]: *** [bootstrap-emacs] Error 255
>   make[2]: Leaving directory `/tmp/jt-ltHmbB/emacs/src'
>   make[1]: *** [src] Error 2
>   make[1]: Leaving directory `/tmp/jt-ltHmbB/emacs'
>   make: *** [bootstrap] Error 2

FYI,

I found that reverting the most recent changes to the offending code
solved that problem:

I reverted part of a55d3b41c25a83197bc02a6a790c6f927088e08f
locally, and can now use GNUS' forwarding once again:
http://repo.or.cz/w/emacs.git/commitdiff/a55d3b41c25a8319

    Synch with Gnus trunk.
    ...
    * mm-util.el (mm-enable-multibyte, mm-disable-multibyte): Use (featurep
    'xemacs) instead of mm-emacs-mule to switch function definitions.
    (mm-with-unibyte-current-buffer): Make it a progn macro for XEmacs.


From 18adba8bf6d112828cce71ddb606027e4ca9ef4b Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Sat, 8 May 2010 15:23:46 +0200
Subject: [PATCH] fix gnus fwding: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6121

---
 lisp/gnus/mm-util.el |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/lisp/gnus/mm-util.el b/lisp/gnus/mm-util.el
index a288b8b..c8952e0 100644
--- a/lisp/gnus/mm-util.el
+++ b/lisp/gnus/mm-util.el
@@ -908,20 +908,20 @@ mail with multiple parts is preferred to sending a Unicode one.")
 			     (fboundp 'set-buffer-multibyte))
     "True in Emacs with Mule.")

-  (if (featurep 'xemacs)
-      (defalias 'mm-enable-multibyte 'ignore)
-    (defun mm-enable-multibyte ()
-      "Set the multibyte flag of the current buffer.
+  (if mm-emacs-mule
+      (defun mm-enable-multibyte ()
+	"Set the multibyte flag of the current buffer.
 Only do this if the default value of `enable-multibyte-characters' is
 non-nil.  This is a no-op in XEmacs."
-      (set-buffer-multibyte t)))
+	(set-buffer-multibyte 'to))
+    (defalias 'mm-enable-multibyte 'ignore))

-  (if (featurep 'xemacs)
-      (defalias 'mm-disable-multibyte 'ignore)
-    (defun mm-disable-multibyte ()
-      "Unset the multibyte flag of in the current buffer.
+  (if mm-emacs-mule
+      (defun mm-disable-multibyte ()
+	"Unset the multibyte flag of in the current buffer.
 This is a no-op in XEmacs."
-      (set-buffer-multibyte nil))))
+	(set-buffer-multibyte nil))
+    (defalias 'mm-disable-multibyte 'ignore)))

 (defun mm-preferred-coding-system (charset)
   ;; A typo in some Emacs versions.
--
1.7.1.166.gf2086

Re: bug#6121: 24.0.50; setting-constant enable-multibyte-characters

[Jim Meyering]

Jim Meyering wrote:

> Jim Meyering wrote:
>> FYI, I've encountered exactly the same problem as described here:
>>
>>   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6121
>>
>> It happens nearly any time I try to forward a message from gnus.
>> I am using the latest built from git.
>>
>> BTW, I noticed that today it fails to build:
>>
>>   Loading bindings (source)...
>>   Loading /mirror/d/emacs/lisp/files.el (source)...
>>   Symbol's function definition is void: define-minor-mode
>>   make[2]: *** [bootstrap-emacs] Error 255
>>   make[2]: Leaving directory `/tmp/jt-ltHmbB/emacs/src'
>>   make[1]: *** [src] Error 2
>>   make[1]: Leaving directory `/tmp/jt-ltHmbB/emacs'
>>   make: *** [bootstrap] Error 2
>
> FYI,
>
> I found that reverting the most recent changes to the offending code
> solved that problem:
>
> I reverted part of a55d3b41c25a83197bc02a6a790c6f927088e08f
> locally, and can now use GNUS' forwarding once again:
> http://repo.or.cz/w/emacs.git/commitdiff/a55d3b41c25a8319
>
>     Synch with Gnus trunk.
>     ...
>     * mm-util.el (mm-enable-multibyte, mm-disable-multibyte): Use (featurep
>     'xemacs) instead of mm-emacs-mule to switch function definitions.
>     (mm-with-unibyte-current-buffer): Make it a progn macro for XEmacs.

Humph.  That was not the cause/fix at all.
I tested the wrong version.
Sorry about that.

That'll teach me not to try to fix things blindly.