From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Howard Melman Newsgroups: gmane.emacs.bugs Subject: bug#16214: Consistency in dired-, occur-, and grep-mode Date: Thu, 17 Feb 2022 11:28:59 -0500 Message-ID: References: <20131221.224043.270400015.tkk@misasa.okayama-u.ac.jp> <87sitl51un.fsf@mail.jurta.org> <20131222.204850.283027925.tkk@misasa.okayama-u.ac.jp> <87ppoo8srl.fsf@mail.jurta.org> <87sfsr9leb.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7614"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (darwin) To: 16214@debbugs.gnu.org Cancel-Lock: sha1:GCaznLwNNIrzJ/e1NGYdJB8j/ig= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 17 17:34:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKjjf-0001l3-3q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Feb 2022 17:34:27 +0100 Original-Received: from localhost ([::1]:58194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKjjd-0006yC-Jo for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Feb 2022 11:34:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKjfQ-0003oM-DF for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 11:30:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58650) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nKjfP-0003NW-50 for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 11:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nKjfO-0003C0-V4 for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 11:30:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <20131221.224043.270400015.tkk@misasa.okayama-u.ac.jp> Resent-From: Howard Melman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Feb 2022 16:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16214 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.164511535212188 (code B ref -1); Thu, 17 Feb 2022 16:30:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Feb 2022 16:29:12 +0000 Original-Received: from localhost ([127.0.0.1]:52547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKjeZ-0003AW-Qn for submit@debbugs.gnu.org; Thu, 17 Feb 2022 11:29:12 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:60104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKjeY-0003AN-Gg for submit@debbugs.gnu.org; Thu, 17 Feb 2022 11:29:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKjeY-00038r-B0 for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 11:29:10 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:39456) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKjeW-0003Aa-Pl for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 11:29:10 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nKjeT-0004yv-UK for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 17:29:05 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227101 Archived-At: I wish this got more traction so here's a small concrete proposal. I think in all three RET already opens the file or line under point (in dired changing the current window, in grep and occur in another window, at least for me on the macport of Emacs 27.2). No changes here. With this one change, o in any of them will open the thing in another window and select that window: (define-key compilation-minor-mode-map (kbd "o") #'compile-goto-error) C-o in all three already opens the thing in another window but not select it, no changes here. I propose no change to C-x C-q in any of the modes, some want just to toggle read-only, dired already enters wdired. This makes e enter a writable version of all three modes. Reserve e in grep-mode (it's already unbound) for a writable version like wdired or occur-edit via a comment or documentation, no code change, no need to mention wgrep in emacs proper. The wgrep package or users can perhaps bind e to wgrep-change-to-wgrep-mode. Make one incompatible change to dired: (define-key dired-mode-map (kbd "e") #'dired-toggle-read-only) Dired users with existing muscle memory to enter wdired via C-x C-q are unchanged. Dired users that use f or RET to edit a file are unchanged; those that use e to edit a file will have to change or bind this themselves. The emacs manual already documents using f to find a file from dired and describes RET and e, in that order, as duplicates of f. With this, e will change to be a duplicate of C-x C-q. In all three you use C-c C-c to apply the edits, no changes here. That's it. 1 comment, 1 new binding and 1 changed binding that already has two other equally convenient (single key) and intuitive bindings. This would make RET, o, C-o, and e consistent in all three as well as saving changes via C-c C-c. I think this will be much easier for new and existing users to remember. -- Howard