From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Howard Melman Newsgroups: gmane.emacs.bugs Subject: bug#74604: 30.0.92; FR: M-x package-upgrade - offer an option to show a diff on upgrade Date: Thu, 05 Dec 2024 17:42:08 -0500 Message-ID: References: <87h67quk0g.fsf@daniel-mendler.de> <87zflfqct7.fsf@posteo.net> <87r06qqx3z.fsf@posteo.net> <87iks2gtl9.fsf@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30250"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 74604@debbugs.gnu.org Cancel-Lock: sha1:/yPKSQv6wIU8w2d1akKBUyJP/m8= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 05 23:43:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJKZ9-0007gm-Bd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Dec 2024 23:43:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJKYq-0005VN-Ey; Thu, 05 Dec 2024 17:43:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJKYo-0005VF-TC for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 17:43:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJKYo-00056f-K7 for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 17:43:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Mime-Version:References:Date:From:To:In-Reply-To:Subject; bh=oTu++zxcIxNVsFZ8vD9PS1NoYigLtd1kRWVMYUjHKb0=; b=dKjPOApacFuCbWXKe53Dd1nXQkO8INfussbOjocPyn/QXTx110kTxK4xA9X0I7DvKaHaYAQ0GdLINBrdbDOECmAgpkP2a7KSjNmPoNTV1xp9Qu3aMDG/OhqNnsZap/kXunw74r04ELD0WxkShGjs0HuvBT5NthrPZ2tlblIOrc16YPtznkcJOtcSFmH9F9aX6hhIW1pfqjq/DmfujThPwPZoAWTF3hKJoaIopP0oDnznp16Ka7z5iqLZ124xsINOqjJEhBAlMcqNIMJg55dfuVCD4rfQkhAwrFyiIVL8MK9Dr0OD1PcLxhCAkBHaq26dOcKBdM/OaSHC6lhzoNvdqQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJKYo-0007uD-6C for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 17:43:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87h67quk0g.fsf@daniel-mendler.de> Resent-From: Howard Melman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2024 22:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74604 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.173343854430335 (code B ref -1); Thu, 05 Dec 2024 22:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Dec 2024 22:42:24 +0000 Original-Received: from localhost ([127.0.0.1]:41321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJKYB-0007tC-KM for submit@debbugs.gnu.org; Thu, 05 Dec 2024 17:42:23 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:50224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJKY9-0007t1-Ss for submit@debbugs.gnu.org; Thu, 05 Dec 2024 17:42:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJKY9-0005MD-MT for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 17:42:21 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJKY8-00054F-FC for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 17:42:21 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1tJKY4-0006kE-Pp for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 23:42:16 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296485 Archived-At: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Ship Mints writes: > >> To help determine the value/risk of a >> package install or update, I'd think it better to show this in advance. >> Daniel's diff suggestion is similar but more technical. > > I think your idea of adding an option to show the change log is good. It > would be nice to have a `package-upgrade-review' option which could be > set to `nil', `news' or to `diff'. There was a package called paradox which had more features on the package UI. It included a command paradox-commit-list that opened a buffer showing one line per commit with the commit message and a button that was a link to the commits diff. It bolded the commits since the current installed version to make it easy to see the changes. It only worked on github hosted packages. It would be great to have this functionality in package.el particularly if it worked on non-github hosted packages. -- Howard