From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pieter van Oostrum Newsgroups: gmane.emacs.bugs Subject: bug#39075: 28.0.50; Emacs hangs on 100% CPU and grows beyond bounds in shell-mode Date: Thu, 16 Jan 2020 20:21:37 +0100 Message-ID: References: <24088.59850.194801.667764@cochabamba.vanoostrum.org> <83y2ue71py.fsf@gnu.org> <83blr87eq1.fsf@gnu.org> <877e1tz9vb.fsf@md5i.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="50147"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: 39075@debbugs.gnu.org To: Michael Welsh Duggan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 16 20:22:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1isAid-000CqG-FJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jan 2020 20:22:15 +0100 Original-Received: from localhost ([::1]:47342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isAic-0001pW-HC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jan 2020 14:22:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46555) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isAiT-0001na-3f for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2020 14:22:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isAiQ-0006J1-Ns for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2020 14:22:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60626) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1isAiQ-0006Ip-Ix for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2020 14:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1isAiQ-0005fW-Da for bug-gnu-emacs@gnu.org; Thu, 16 Jan 2020 14:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pieter van Oostrum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jan 2020 19:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39075 X-GNU-PR-Package: emacs Original-Received: via spool by 39075-submit@debbugs.gnu.org id=B39075.157920251321775 (code B ref 39075); Thu, 16 Jan 2020 19:22:02 +0000 Original-Received: (at 39075) by debbugs.gnu.org; 16 Jan 2020 19:21:53 +0000 Original-Received: from localhost ([127.0.0.1]:38366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isAiG-0005f9-Nc for submit@debbugs.gnu.org; Thu, 16 Jan 2020 14:21:52 -0500 Original-Received: from smarthost-a.hosting2go.nl ([83.137.198.201]:38717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isAiC-0005ew-SV for 39075@debbugs.gnu.org; Thu, 16 Jan 2020 14:21:51 -0500 X-ASG-Debug-ID: 1579202502-0ac37b1e5516221a0001-ZIxEMc Original-Received: from server24.hosting2go.nl (server24.hosting2go.nl [83.137.194.11]) by smarthost-a.hosting2go.nl with ESMTP id vZjRdYivLJ6HAS9Q (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for <39075@debbugs.gnu.org>; Thu, 16 Jan 2020 20:21:42 +0100 (CET) X-Barracuda-Envelope-From: pieter-l@vanoostrum.org X-Barracuda-Effective-Source-IP: server24.hosting2go.nl[83.137.194.11] X-Barracuda-Apparent-Source-IP: 83.137.194.11 Original-Received: (qmail 7039 invoked from network); 16 Jan 2020 19:21:41 -0000 Original-Received: from static-145.132.212.31.ip.telfort.nl (HELO cochabamba.vanoostrum.org) (145.132.212.31) by server24.hosting2go.nl with SMTP; 16 Jan 2020 19:21:41 -0000 Received-SPF: unknown (server24.hosting2go.nl: domain at 83.137.194.9 does not designate permitted sender hosts) Original-Received: from cochabamba.vanoostrum.org (localhost [IPv6:::1]) by cochabamba.vanoostrum.org (Postfix) with ESMTP id 9D1D3A6A0BD7; Thu, 16 Jan 2020 20:21:38 +0100 (CET) X-ASG-Orig-Subj: Re: bug#39075: 28.0.50; Emacs hangs on 100% CPU and grows beyond bounds in shell-mode In-Reply-To: (Pieter van Oostrum's message of "Wed, 15 Jan 2020 20:15:03 +0100") X-Barracuda-Connect: server24.hosting2go.nl[83.137.194.11] X-Barracuda-Start-Time: 1579202502 X-Barracuda-Encrypted: ECDHE-RSA-AES256-GCM-SHA384 X-Barracuda-URL: https://83.137.198.201:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at hosting2go.nl X-Barracuda-Scan-Msg-Size: 699 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 1.04 X-Barracuda-Spam-Status: No, SCORE=1.04 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.5 tests=BSF_SC0_MISMATCH_TO, FS_LARGE_PERCENT2 A-X-Hosting2GO-Smarthost: Clean X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.79381 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 1.04 FS_LARGE_PERCENT2 Larger than 100% in subj. 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174735 Archived-At: --=-=-= Content-Type: text/plain Pieter van Oostrum writes: > Michael Welsh Duggan writes: > >> This seems very similar to the bug I reported at bug#38549. Could you >> see if this also fixes that recipe and, if so, merge the bugs? >> > Yes, the same fix solves that bug also. It is the same bug. I propose to amend the test also, so that it would have caught this error (by hanging). I add both patches here now. I have tested that all other things worked the same and found no problems. Is there an official procedure for requesting the change, or is posting it here sufficient? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=shell.patch diff --git a/lisp/shell.el b/lisp/shell.el index 98e830ee49..ecebf937e2 100644 --- a/lisp/shell.el +++ b/lisp/shell.el @@ -428,7 +428,7 @@ shell--parse-pcomplete-arguments (save-excursion (goto-char begin) (while (< (point) end) - (skip-chars-forward " \t\n") + (skip-chars-forward " \t\n;") (push (point) begins) (let ((arg ())) (while (looking-at diff --git a/test/lisp/shell-tests.el b/test/lisp/shell-tests.el index 6d262f8e7c..7113cb941c 100644 --- a/test/lisp/shell-tests.el +++ b/test/lisp/shell-tests.el @@ -34,8 +34,7 @@ shell-tests-completion-before-semi (with-temp-buffer (shell-mode) (insert "cd ba;") - (forward-char -1) (should (equal (shell--parse-pcomplete-arguments) - '(("cd" "ba") 1 4))))) + '(("cd" "ba" "") 1 4))))) ;;; shell-tests.el ends here --=-=-= Content-Type: text/plain -- Pieter van Oostrum www: http://pieter.vanoostrum.org/ PGP key: [8DAE142BE17999C4] --=-=-=--