unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#10842: Cancelling a new mail in message-mode ignores rmail-mail-new-frame
@ 2012-02-18 22:02 Glenn Morris
  2012-02-20  8:28 ` Lars Ingebrigtsen
  2019-09-23 15:12 ` Lars Ingebrigtsen
  0 siblings, 2 replies; 7+ messages in thread
From: Glenn Morris @ 2012-02-18 22:02 UTC (permalink / raw)
  To: 10842

Package: emacs
Version: 24.0.93
Severity: minor

emacs -Q \
  --eval "(setq rmail-mail-new-frame t mail-user-agent 'sendmail-user-agent)"
M-x rmail
m
  -> new frame appears for mail composition
Choose Mail menu, Cancel
  -> frame disappears

repeat with the default message-user-agent:

Choose Message menu, Kill Message
   -> frame does not disappear


If you fix this, you can restore (a suitably modified version of) this
commented-out text in rmail.texi:

@ignore
@c FIXME does not work with Message -> Kill Message
, or when you use the @samp{Cancel} item in the @samp{Mail} menu.
@end ignore






^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#10842: Cancelling a new mail in message-mode ignores rmail-mail-new-frame
  2012-02-18 22:02 bug#10842: Cancelling a new mail in message-mode ignores rmail-mail-new-frame Glenn Morris
@ 2012-02-20  8:28 ` Lars Ingebrigtsen
  2012-02-20 19:05   ` Glenn Morris
  2019-09-23 15:12 ` Lars Ingebrigtsen
  1 sibling, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2012-02-20  8:28 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 10842

Glenn Morris <rgm@gnu.org> writes:

> emacs -Q \
>   --eval "(setq rmail-mail-new-frame t mail-user-agent 'sendmail-user-agent)"
> M-x rmail
> m

[...]

> Choose Message menu, Kill Message
>    -> frame does not disappear

This is an rmail bug and not a Message bug, I guess?

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Sent from my Rome





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#10842: Cancelling a new mail in message-mode ignores rmail-mail-new-frame
  2012-02-20  8:28 ` Lars Ingebrigtsen
@ 2012-02-20 19:05   ` Glenn Morris
  2012-03-09 23:34     ` Lars Magne Ingebrigtsen
  0 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2012-02-20 19:05 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 10842

Lars Ingebrigtsen wrote:

> This is an rmail bug and not a Message bug, I guess?

I don't really see how it could be. At first glance, it seems that
message-kill-buffer does not run message-bury, and hence does not
process the return-action of compose-mail. Compare with
message-dont-send, which does delete the frame.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#10842: Cancelling a new mail in message-mode ignores rmail-mail-new-frame
  2012-02-20 19:05   ` Glenn Morris
@ 2012-03-09 23:34     ` Lars Magne Ingebrigtsen
  0 siblings, 0 replies; 7+ messages in thread
From: Lars Magne Ingebrigtsen @ 2012-03-09 23:34 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 10842

Glenn Morris <rgm@gnu.org> writes:

> I don't really see how it could be. At first glance, it seems that
> message-kill-buffer does not run message-bury, and hence does not
> process the return-action of compose-mail. Compare with
> message-dont-send, which does delete the frame.

I see.  Well, I don't use either rmail nor use pop-up frames, so I'm
probably the wrong person to try to fix this.  Unless absolutely nobody
else can, that is...

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#10842: Cancelling a new mail in message-mode ignores rmail-mail-new-frame
  2012-02-18 22:02 bug#10842: Cancelling a new mail in message-mode ignores rmail-mail-new-frame Glenn Morris
  2012-02-20  8:28 ` Lars Ingebrigtsen
@ 2019-09-23 15:12 ` Lars Ingebrigtsen
  2019-09-27 16:31   ` Glenn Morris
  1 sibling, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2019-09-23 15:12 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 10842

Glenn Morris <rgm@gnu.org> writes:

> emacs -Q \
>   --eval "(setq rmail-mail-new-frame t mail-user-agent 'sendmail-user-agent)"
> M-x rmail
> m
>   -> new frame appears for mail composition
> Choose Mail menu, Cancel
>   -> frame disappears

And it should disappear, so that's the bug?  What command does that
"Cancel" menu run?

Glenn Morris <rgm@gnu.org> writes:

> Lars Ingebrigtsen wrote:
>
>> This is an rmail bug and not a Message bug, I guess?
>
> I don't really see how it could be. At first glance, it seems that
> message-kill-buffer does not run message-bury, and hence does not
> process the return-action of compose-mail. Compare with
> message-dont-send, which does delete the frame.

message-dont-send is return-action, which is documented as

---
RETURN-ACTION, if non-nil, is an action for returning to the
caller.  It has the form (FUNCTION . ARGS).  The function is
called after the mail has been sent or put aside, and the mail
buffer buried.
---

message-kill-buffer isn't what's meant by return-action in the
compose-mail interface, I think?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#10842: Cancelling a new mail in message-mode ignores rmail-mail-new-frame
  2019-09-23 15:12 ` Lars Ingebrigtsen
@ 2019-09-27 16:31   ` Glenn Morris
  2019-09-29  9:32     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2019-09-27 16:31 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 10842


I don't know how to explain it any better than in the OP.
The intent of the Rmail code is that discarding a draft should delete
the frame. It works with mail mode but not message mode.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#10842: Cancelling a new mail in message-mode ignores rmail-mail-new-frame
  2019-09-27 16:31   ` Glenn Morris
@ 2019-09-29  9:32     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 7+ messages in thread
From: Lars Ingebrigtsen @ 2019-09-29  9:32 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 10842

Glenn Morris <rgm@gnu.org> writes:

> I don't know how to explain it any better than in the OP.
> The intent of the Rmail code is that discarding a draft should delete
> the frame. It works with mail mode but not message mode.

Message has two ways of returning to the caller (while not sending
anything).  message-dont-send runs RETURN-ACTION (which is presumably
what Rmail uses to close the frame etc), while message-kill-buffer does
not run RETURN-ACTION.

I don't see how to reconcile that on the Message side.

Rmail could set message-kill-actions to whatever it wants, which is why
I think this is an Rmail bug.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-09-29  9:32 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-18 22:02 bug#10842: Cancelling a new mail in message-mode ignores rmail-mail-new-frame Glenn Morris
2012-02-20  8:28 ` Lars Ingebrigtsen
2012-02-20 19:05   ` Glenn Morris
2012-03-09 23:34     ` Lars Magne Ingebrigtsen
2019-09-23 15:12 ` Lars Ingebrigtsen
2019-09-27 16:31   ` Glenn Morris
2019-09-29  9:32     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).