From: Kaushal Modi <kaushal.modi@gmail.com>
To: 21619@debbugs.gnu.org
Subject: bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords
Date: Mon, 5 Oct 2015 16:28:41 +0000 (UTC) [thread overview]
Message-ID: <loom.20151005T182448-485@post.gmane.org> (raw)
In-Reply-To: <CAAdUY-JRmho+Z_O3wg0=Y3xuknP0Vw2L17ydbhyWoj3-wvgG+g@mail.gmail.com>
Artur Malabarba <bruce.connor.am <at> gmail.com> writes:
>
> The docstring for this function (when displayed in a help buffer) has
> the following code-snippet, which clearly has the wrong type of
> quotes.
>
> (font-lock-add-keywords ’c-mode
> ’(("\\<\\(FIXME\\):" 1 ’font-lock-warning-face prepend)
> ("\\<\\(and\\|or\\|not\\)\\>" . ’font-lock-keyword-face)))
>
> Instead of fixing this by manually escaping them, how about we change
> the algorithm to only convert `...' quotes if the ... is a single
> symbol?
>
>
Looks like it got fixed in this commit:
http://git.savannah.gnu.org/cgit/emacs.git/commit/?
id=47e9556c70a7009d7c750fd7bf10a0e6cf41cdce
- (sql-add-product-keywords 'ms
- '((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
+ (sql-add-product-keywords \\='ms
+ \\='((\"\\\\b\\\\w+_t\\\\b\" . font-lock-type-face)))
But while grepping for "’\([a-z(]+" in the emacs repo base dir, I found
just this one case that yet needs to be fixed:
Line 1013 of htmlfontify.info
’((class color grayscale) (type tty)) would match any of:
'((class color))
'((class grayscale))
next prev parent reply other threads:[~2015-10-05 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 14:24 bug#21619: 25.0.50; Wrong curly quotes in the docstring for font-lock-add-keywords Artur Malabarba
2015-10-05 16:28 ` Kaushal Modi [this message]
2015-10-06 9:15 ` Artur Malabarba
2015-10-06 10:20 ` Kaushal Modi
2015-10-06 10:41 ` Artur Malabarba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20151005T182448-485@post.gmane.org \
--to=kaushal.modi@gmail.com \
--cc=21619@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).