From: Glenn Morris <rgm@gnu.org>
To: 14967@debbugs.gnu.org
Cc: lunaryorn@gmail.com, Stefan Monnier <monnier@IRO.UMontreal.CA>,
Alex <agrambot@gmail.com>,
npostavs@users.sourceforge.net
Subject: bug#14967: 24.3.50; package-delete deletes by trashing?
Date: Mon, 19 Jun 2017 14:47:52 -0400 [thread overview]
Message-ID: <leshivn7af.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <ocr2yp6j6x.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 12 Jun 2017 16:32:22 -0400")
I've applied the following.
IMO if Emacs wants to behave like system package managers (eg yum, apt),
it should (optionally) cache the _source_ when it downloads a package.
Then use that (if appropriate) if asked to (re)install.
commit 65b323e (HEAD, master)
Date: Mon Jun 19 14:39:25 2017 -0400
Don't put deleted packages in the trash (bug#14967)
* lisp/emacs-lisp/package.el (package-delete):
Don't pay attention to delete-by-moving-to-trash.
; * etc/NEWS: Mention this.
diff --git a/etc/NEWS b/etc/NEWS
index 85d1273..78d37484 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -755,6 +755,9 @@ header's value.
where the GnuPG home directory (used for signature verification) is
located and whether GnuPG's option "--homedir" is used or not.
+---
+*** Deleting a package no longer respects 'delete-by-moving-to-trash'.
+
** Tramp
+++
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index bebfd18..4245294 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2127,7 +2127,7 @@ If NOSAVE is non-nil, the package is not removed from
(package-desc-name pkg-used-elsewhere-by)))
(t
(add-hook 'post-command-hook #'package-menu--post-refresh)
- (delete-directory dir t t)
+ (delete-directory dir t)
;; Remove NAME-VERSION.signed and NAME-readme.txt files.
(dolist (suffix '(".signed" "readme.txt"))
(let* ((version (package-version-join (package-desc-version pkg-desc)))
next prev parent reply other threads:[~2017-06-19 18:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-27 10:30 bug#14967: 24.3.50; package-delete deletes by trashing? Sebastian Wiesner
2013-07-29 22:02 ` Glenn Morris
2013-07-30 10:51 ` Sebastian Wiesner
2013-07-30 14:21 ` Stefan Monnier
2013-07-30 14:40 ` Sebastian Wiesner
2013-07-30 15:14 ` Stefan Monnier
2016-08-05 23:40 ` npostavs
2016-09-03 4:06 ` Alex
2017-06-11 23:58 ` npostavs
2017-06-12 3:26 ` Alex
2017-06-12 14:27 ` Eli Zaretskii
2017-06-12 16:03 ` Glenn Morris
2017-06-12 16:33 ` Eli Zaretskii
2017-06-12 16:56 ` Glenn Morris
2017-06-12 17:02 ` Stefan Monnier
2017-06-14 2:54 ` Richard Stallman
2017-06-12 17:04 ` Eli Zaretskii
2017-06-12 17:17 ` Stefan Monnier
2017-06-12 19:45 ` Alex
2017-06-12 20:32 ` Glenn Morris
2017-06-13 3:50 ` Alex
2017-06-19 18:47 ` Glenn Morris [this message]
2017-06-12 19:37 ` Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=leshivn7af.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=14967@debbugs.gnu.org \
--cc=agrambot@gmail.com \
--cc=lunaryorn@gmail.com \
--cc=monnier@IRO.UMontreal.CA \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).