From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#17187: 24.3.50.1 open-dribble-file stores pw Date: Sat, 05 Apr 2014 19:01:40 -0400 Message-ID: References: <533EED70.9090709@easy-emacs.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1396738953 2929 80.91.229.3 (5 Apr 2014 23:02:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Apr 2014 23:02:33 +0000 (UTC) Cc: 17187@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 06 01:02:27 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WWZbC-00053a-Pp for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Apr 2014 01:02:06 +0200 Original-Received: from localhost ([::1]:56076 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWZbC-0003H4-EQ for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Apr 2014 19:02:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWZb9-0003Gv-8J for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2014 19:02:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WWZb8-00081z-GT for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2014 19:02:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWZb8-00081v-DI for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2014 19:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WWZb7-0002iC-OI for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2014 19:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Apr 2014 23:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17187 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17187-submit@debbugs.gnu.org id=B17187.139673890410384 (code B ref 17187); Sat, 05 Apr 2014 23:02:01 +0000 Original-Received: (at 17187) by debbugs.gnu.org; 5 Apr 2014 23:01:44 +0000 Original-Received: from localhost ([127.0.0.1]:37159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWZap-0002hQ-KQ for submit@debbugs.gnu.org; Sat, 05 Apr 2014 19:01:44 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:42515) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWZan-0002hI-86 for 17187@debbugs.gnu.org; Sat, 05 Apr 2014 19:01:41 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WWZam-0007dh-9w; Sat, 05 Apr 2014 19:01:40 -0400 X-Spook: cracking asset chameleon man Clinton CDC SRI spy Bosnia X-Ran: l,,jfhsbxLj*c6NcHmlgDT1]lE7R+C:su6;7Ow$j_J_pdC;`xtsrw$@l~u4Izv#HO0Ifl> X-Hue: green X-Attribution: GM In-Reply-To: (Stefan Monnier's message of "Sat, 05 Apr 2014 18:02:53 -0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87784 Archived-At: Lightly tested: *** src/keyboard.c 2014-04-05 18:33:55 +0000 --- src/keyboard.c 2014-04-05 22:59:00 +0000 *************** *** 20,25 **** --- 20,26 ---- #include #include "sysstdio.h" + #include #include "lisp.h" #include "termchar.h" *************** *** 10085,10092 **** } if (!NILP (file)) { file = Fexpand_file_name (file, Qnil); ! dribble = emacs_fopen (SSDATA (file), "w"); if (dribble == 0) report_file_error ("Opening dribble", file); } --- 10086,10100 ---- } if (!NILP (file)) { + int fd; file = Fexpand_file_name (file, Qnil); ! if (! NILP (Ffile_exists_p (file))) ! { ! if (chmod (SSDATA (file), 0600) < 0) ! report_file_error ("Doing chmod", file); ! } ! fd = emacs_open (SSDATA (file), O_WRONLY | O_CREAT | O_TRUNC, 0600); ! dribble = fd < 0 ? 0 : fdopen (fd, "w"); if (dribble == 0) report_file_error ("Opening dribble", file); }