bug#6979: In compilation buffer, 'gnu-include' rule is not working as intended

bug#6979: In compilation buffer, 'gnu-include' rule is not working as intended

[Paul Pogonyshev]

[-- Attachment #1: Type: Text/Plain, Size: 489 bytes --]

Example file 'compilation.txt' claims it is supported to mark only the
last message as the error, skipping all 'included from...' lines,
which are often not interesting.  However, instead it marks all lines
except the first as errors.

To reproduce:

    M-x customize-variable
    compilation-error-regexp-alist

and follow the 'see also example file' link.

Screenshot of what I see is attached.

GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.20.1) of 2010-09-02 on gonzo

Paul

[-- Attachment #2: emacs-gcc-include.png --]
[-- Type: image/png, Size: 12342 bytes --]

bug#6979: More information

[Paul Pogonyshev]

I've found that 'gcc-include' rule is wrongly overriden by 'ruby': if
I disable the latter in 'compilation-error-regexp-alist', highlighting
is back to normal.  I'm not sure what a correct fix would be.  Maybe
ruby error highlighting should also highlight 'from' lines as info,
not errors.

bug#6979: More information

[Chong Yidong]

Paul Pogonyshev <pogonyshev@gmx.net> writes:

> I've found that 'gcc-include' rule is wrongly overriden by 'ruby': if
> I disable the latter in 'compilation-error-regexp-alist', highlighting
> is back to normal.  I'm not sure what a correct fix would be.  Maybe
> ruby error highlighting should also highlight 'from' lines as info,
> not errors.

Could you please provide some examples?

bug#6979: More information

[Paul Pogonyshev]

Chong Yidong wrote:
> Paul Pogonyshev <pogonyshev@gmx.net> writes:
> 
> > I've found that 'gcc-include' rule is wrongly overriden by 'ruby': if
> > I disable the latter in 'compilation-error-regexp-alist', highlighting
> > is back to normal.  I'm not sure what a correct fix would be.  Maybe
> > ruby error highlighting should also highlight 'from' lines as info,
> > not errors.
> 
> Could you please provide some examples?

As I wrote in my original mail:

> To reproduce:
>
>     M-x customize-variable
>     compilation-error-regexp-alist
>
> and follow the 'see also example file' link.

Look for the string 'gcc-include' in the example.  In description it
claims that the first two lines would be highlighted as information
and the last as error.  In reality, second line:

                 from /usr/include/c++/3.3/backward/iostream.h:31,

is also highlighted as an error because it is handled by 'ruby' rule.

I would also argue that _all three_ lines should be information
because real error follows those, but that is a different issue.

Paul

bug#6979: More information

[Glenn Morris]

I imagine this (likewise bug#6966?) has been fixed by the 2010-09-04
change to compile.el, could you confirm?

bug#6979: More information

[Paul Pogonyshev]

Glenn Morris wrote:
> I imagine this (likewise bug#6966?) has been fixed by the 2010-09-04
> change to compile.el, could you confirm?

Yes, it is fixed, but I don't know how to close bugs in this system.

Paul

bug#6979: More information

[Eli Zaretskii]

> From: Paul Pogonyshev <pogonyshev@gmx.net>
> Date: Thu, 16 Sep 2010 21:35:31 +0300
> Cc: 6979@debbugs.gnu.org
> 
> Glenn Morris wrote:
> > I imagine this (likewise bug#6966?) has been fixed by the 2010-09-04
> > change to compile.el, could you confirm?
> 
> Yes, it is fixed, but I don't know how to close bugs in this system.

Reply to 6979-done@debbugs.gnu.org to cause bug #6979 be closed.