From: Glenn Morris <rgm@gnu.org>
To: Leo Liu <sdl.web@gmail.com>
Cc: 16038@debbugs.gnu.org
Subject: bug#16038: 24.3; latest change to with-help-window makes temp-buffer-browse useless
Date: Mon, 07 Jul 2014 21:54:35 -0400 [thread overview]
Message-ID: <ky8uo41up0.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <m1ha974djd.fsf@gmail.com> (Leo Liu's message of "Tue, 14 Jan 2014 08:23:18 +0800")
Leo Liu wrote:
> Could we remove the following two add-hooks?
>
>
> --8<---------------cut here---------------start------------->8---
> (add-hook 'temp-buffer-setup-hook 'help-mode-setup)
> (add-hook 'temp-buffer-show-hook 'help-mode-finish)
> --8<---------------cut here---------------end--------------->8---
If you want to do this (I know you already did...), you need to add an
incompatible change entry to NEWS about this, and you need to audit
every single use of with-output-to-temp-buffer to find the ones that
expected their output buffers to be in help mode. Which I guess would
be, umm, all of them?
The first one I tried:
emacs -Q -f report-emacs-bug
*Bug Help* buffer is in Help mode in 24.3.92, and fundamental in trunk.
Does it actually matter in that case? Maybe not, but the buffer was
clearly intended te be in help mode.
And here's a case where it definitely does matter
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17966
(This report has become rather long; I hope it doesn't get too much longer.)
next prev parent reply other threads:[~2014-07-08 1:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 14:34 bug#16038: 24.3; latest change to with-help-window makes temp-buffer-browse useless Leo Liu
2014-01-11 14:01 ` martin rudalics
2014-01-11 14:32 ` Leo Liu
2014-01-11 15:41 ` martin rudalics
2014-01-11 16:31 ` Leo Liu
2014-01-12 9:53 ` martin rudalics
2014-01-14 0:23 ` Leo Liu
2014-01-14 1:47 ` Stefan Monnier
2014-01-14 4:42 ` Leo Liu
2014-01-14 21:38 ` Stefan Monnier
2014-01-14 21:55 ` Drew Adams
2014-01-14 23:46 ` Leo Liu
2014-01-22 2:14 ` Leo Liu
2014-01-22 3:02 ` Stefan Monnier
2014-01-22 3:32 ` Leo Liu
2014-01-22 13:44 ` Stefan Monnier
2014-01-23 10:03 ` Leo Liu
2014-01-23 17:48 ` Drew Adams
2014-01-24 7:30 ` Leo Liu
2014-01-24 15:06 ` Drew Adams
2014-01-24 15:45 ` martin rudalics
2014-01-24 16:29 ` Drew Adams
2014-01-25 9:21 ` martin rudalics
2014-01-25 16:34 ` Drew Adams
2014-01-25 16:48 ` martin rudalics
2014-01-25 17:33 ` Drew Adams
2014-01-25 18:25 ` martin rudalics
2014-01-25 20:19 ` Drew Adams
2014-01-26 11:24 ` martin rudalics
2014-01-26 17:52 ` Drew Adams
2014-01-27 8:21 ` martin rudalics
2014-01-27 15:14 ` Drew Adams
2014-01-22 3:07 ` Glenn Morris
2014-07-08 1:54 ` Glenn Morris [this message]
2014-07-08 2:04 ` Glenn Morris
2014-07-08 5:59 ` Glenn Morris
2014-07-08 13:57 ` Drew Adams
2014-07-08 22:24 ` Leo Liu
2014-07-10 7:20 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ky8uo41up0.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=16038@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).