unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: 13523@debbugs.gnu.org
Cc: Chong Yidong <cyd@gnu.org>
Subject: bug#13523: 24.2.92; [regression] mark-active
Date: Wed, 23 Jan 2013 03:06:10 -0500	[thread overview]
Message-ID: <kvobgg2uj1.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <m2zk01hceu.fsf@gmail.com> (Leo Liu's message of "Tue, 22 Jan 2013 16:03:53 +0800")


So IIUC the issue can be summarized as:

down-mouse-1 runs mouse-drag-region
mouse-1 runs mouse-set-point

mouse-drag-region calls mouse-drag-track.
Since 2010-07-03 (I think), this unconditionally pushes mark.

It then uses track-mouse to watch for further mouse events.
If at the end, point has not moved and the last event was
mouse-set-point or mouse-set-region, it deactivates and pops the mark.

Otherwise it assumes it is handling a multi-click event (since
2010-07-05), and does not deactivate mark.

The result is that if you bind mouse-1 to something other than
mouse-set-point, and leave down-mouse-1 alone, then after a mouse-1 click
the mark stays active (unless you specifically deactivate it).

Examples can be seen with image-dired and rst-toc-mode, which both bind
mouse-1 but not down-mouse-1. In both cases, mouse-1 clicks leave the
mouse active. It doesn't seem to matter in either case, but probably is
not intended.

Is the intention that people bind down-mouse-1 as well/instead of
mouse-1, or that things bound to mouse-1 deactivate mark, or can the
multi-click detection be changed somehow to avoid this?





  parent reply	other threads:[~2013-01-23  8:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-22  8:03 bug#13523: 24.2.92; [regression] mark-active Leo Liu
2013-01-22  8:28 ` Dmitry Gutov
2013-01-22  8:59   ` Leo Liu
2013-01-23  8:06 ` Glenn Morris [this message]
2013-01-23 12:48   ` Stefan Monnier
2013-01-27  2:16     ` Glenn Morris
2013-01-28  1:33       ` Stefan Monnier
2013-01-30  2:00         ` Glenn Morris
2013-01-31  2:47           ` Stefan Monnier
2013-01-31  3:34             ` Glenn Morris
2013-01-31  7:21               ` Glenn Morris
2013-01-31  7:48                 ` Glenn Morris
2013-01-31 14:47               ` Stefan Monnier
2013-02-01 23:41             ` Stefan Monnier
2013-01-24  1:20   ` Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=kvobgg2uj1.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=13523@debbugs.gnu.org \
    --cc=cyd@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).