From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: pok@netfonds.no (Peder O. Klingenberg) Newsgroups: gmane.emacs.bugs Subject: bug#27230: eldoc doc Date: Thu, 14 Sep 2017 13:47:27 +0200 Message-ID: References: <282e174a-e9c0-6bec-32f5-ed9d772e5e1d@yandex.ru> <83efu8ta6n.fsf@gnu.org> <4107369a-5d50-7e46-2e81-57c4ef5c7965@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505389697 13327 195.159.176.226 (14 Sep 2017 11:48:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 14 Sep 2017 11:48:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: "Charles A. Roelli" , 27230@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 14 13:48:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsScv-0003HG-9x for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Sep 2017 13:48:13 +0200 Original-Received: from localhost ([::1]:47082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsSd1-0006Do-4S for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Sep 2017 07:48:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsScs-00068u-AK for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 07:48:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsScm-0000H5-Fd for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 07:48:10 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59338) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dsScm-0000GI-BO for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 07:48:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dsSck-000634-7g for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 07:48:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: pok@netfonds.no (Peder O. Klingenberg) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Sep 2017 11:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27230-submit@debbugs.gnu.org id=B27230.150538965223195 (code B ref 27230); Thu, 14 Sep 2017 11:48:02 +0000 Original-Received: (at 27230) by debbugs.gnu.org; 14 Sep 2017 11:47:32 +0000 Original-Received: from localhost ([127.0.0.1]:39781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsScF-000622-QT for submit@debbugs.gnu.org; Thu, 14 Sep 2017 07:47:31 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:47046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsScE-00061v-Cp for 27230@debbugs.gnu.org; Thu, 14 Sep 2017 07:47:30 -0400 Original-Received: from luna.netfonds.no ([80.91.225.79]) by hermes.netfonds.no with esmtp (Exim 4.84_2) (envelope-from ) id 1dsScB-0005ZH-6O; Thu, 14 Sep 2017 13:47:28 +0200 Original-Received: by luna.netfonds.no (Postfix, from userid 547) id 46C124E00A4; Thu, 14 Sep 2017 13:47:27 +0200 (CEST) ..Peder...From: pok@netfonds.no (Peder O. Klingenberg) In-Reply-To: <4107369a-5d50-7e46-2e81-57c4ef5c7965@yandex.ru> (Dmitry Gutov's message of "Mon, 26 Jun 2017 04:04:18 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136955 Archived-At: On Mon, Jun 26 2017 at 04:04, Dmitry Gutov wrote: > On 6/25/17 10:47 PM, Charles A. Roelli wrote: > >> FORMAT-STRING (or nil, if not given) is stored in >> `eldoc-last-message'. If ARGS are given, FORMAT-STRING is first >> formatted through `format-message'. > > I wonder if we ever call this function with more than one argument. If > not, the code and the doc call for simplification. We can avoid > advertising this possibility, at least. As I discovered today, when I updated my tree, there are callers outside emacs core that do call eldoc-message with more than one argument. slime-autodoc.el is one such package, which I use. The slime project has an open issue on this, with a patch, but it hasn't been applied yet, after sitting in the discussion for 17 days. IMO commit 7ef0b5f611c2d56ac2edb8de287190f04c4b8f32 was an ill-advised change. The code worked fine before, the cleanup afforded by breaking the api was negligible. I think it should be reverted. (Slime would benefit from cleaing up their callers as well, no doubt, but not every slime user should be forced to do that on their own. And there may be more third-party, infrequently maintained packages using eldoc.) ...Peder... -- This must be Thursday. I never could get the hang of Thursdays.