From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: peder@klingenberg.no (Peder O. Klingenberg) Newsgroups: gmane.emacs.bugs Subject: bug#24315: 25.1.50; re-search-forward errors with "Variable binding depth exceeds max-specpdl-size" Date: Tue, 06 Sep 2016 10:18:13 +0200 Message-ID: References: <87twe6sx2g.fsf@users.sourceforge.net> <87poonoyer.fsf@users.sourceforge.net> <87inudnjxf.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1473150169 10234 195.159.176.226 (6 Sep 2016 08:22:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Sep 2016 08:22:49 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: 24315@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 06 10:22:44 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhBeH-0000qf-9i for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2016 10:22:29 +0200 Original-Received: from localhost ([::1]:59840 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhBeF-0006Qc-45 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2016 04:22:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhBb1-0003YX-O5 for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 04:19:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhBaw-00082M-Kw for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 04:19:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53151) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhBaw-00082G-I5 for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 04:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bhBaw-0005O7-CR for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2016 04:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: peder@klingenberg.no (Peder O. Klingenberg) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2016 08:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24315-submit@debbugs.gnu.org id=B24315.147314990320665 (code B ref 24315); Tue, 06 Sep 2016 08:19:02 +0000 Original-Received: (at 24315) by debbugs.gnu.org; 6 Sep 2016 08:18:23 +0000 Original-Received: from localhost ([127.0.0.1]:50863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhBaI-0005NE-Ok for submit@debbugs.gnu.org; Tue, 06 Sep 2016 04:18:23 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:51628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhBaG-0005N4-TR for 24315@debbugs.gnu.org; Tue, 06 Sep 2016 04:18:21 -0400 Original-Received: from luna.netfonds.no ([80.91.225.79] helo=luna) by hermes.netfonds.no with esmtp (Exim 4.84_2) (envelope-from ) id 1bhBa9-0007pp-Vs; Tue, 06 Sep 2016 10:18:16 +0200 Original-Received: by luna (Postfix, from userid 547) id EB9724E00E5; Tue, 6 Sep 2016 10:18:13 +0200 (CEST) In-Reply-To: <87inudnjxf.fsf@users.sourceforge.net> (npostavs's message of "Sat, 03 Sep 2016 10:21:16 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122982 Archived-At: --=-=-= Content-Type: text/plain On Sat, Sep 03 2016 at 10:21, npostavs@users.sourceforge.net wrote: > Patch looks good, though I think the description shouldn't say "crash", > since the problem is a regex stack overflow, which is just a normal > Emacs error I agree, that was a poor choice of words. How about this? --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=bug24315.patch >From bd28797ce52c070e59d26483bdf842fd31651de6 Mon Sep 17 00:00:00 2001 From: "Peder O. Klingenberg" Date: Tue, 30 Aug 2016 14:44:16 +0200 Subject: [PATCH] Avoid error in icalendar--read-element * lisp/calendar/icalendar.el (icalendar--read-element): Avoid a regex stack overflow by not using regex to extract values from calendar events. (Bug#24315) --- lisp/calendar/icalendar.el | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lisp/calendar/icalendar.el b/lisp/calendar/icalendar.el index 386c554..c88f4ab 100644 --- a/lisp/calendar/icalendar.el +++ b/lisp/calendar/icalendar.el @@ -361,7 +361,8 @@ icalendar--read-element INVALUE gives the current iCalendar element we are reading. INPARAMS gives the current parameters..... This function calls itself recursively for each nested calendar element -it finds." +it finds. The current buffer should be an unfolded buffer as returned +from `icalendar--get-unfolded-buffer'." (let (element children line name params param param-name param-value value (continue t)) @@ -391,8 +392,9 @@ icalendar--read-element (unless (looking-at ":") (error "Oops")) (forward-char 1) - (re-search-forward "\\(.*\\)\\(\r?\n[ \t].*\\)*" nil t) - (setq value (icalendar--rris "\r?\n[ \t]" "" (match-string 0))) + (let ((start (point))) + (end-of-line) + (setq value (buffer-substring start (point)))) (setq line (list name params value)) (cond ((eq name 'BEGIN) (setq children -- 2.9.3 --=-=-=--