From: Glenn Morris <rgm@gnu.org>
To: charles@aurox.ch (Charles A. Roelli)
Cc: 28732@debbugs.gnu.org
Subject: bug#28732: flymake mouse-wheel portability fix
Date: Mon, 26 Feb 2018 16:38:50 -0500 [thread overview]
Message-ID: <k4fu5n5t3p.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <m2shevkm93.fsf@aurox.ch> (Charles A. Roelli's message of "Sat, 07 Oct 2017 17:31:36 +0200")
Hi,
This change causes errors in without-x builds.
At compile-time:
In flymake--mode-line-format:
progmodes/flymake.el:1086:49:Warning: reference to free variable
`mouse-wheel-down-event'
progmodes/flymake.el:1092:49:Warning: reference to free variable
`mouse-wheel-up-event'
At run-time:
Error during redisplay: (eval (flymake--mode-line-format)) signaled
(void-variable mouse-wheel-down-event)
Charles A. Roelli wrote:
> The flymake mode line mouse-wheel scroll thing needs the following fix
> to be more portable.
>
> This change also removes an extra newline at the end of the tooltip,
> which doesn't have to be there as far as I can see.
>
> diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
> index 45f0adf..007de8f 100644
> --- a/lisp/progmodes/flymake.el
> +++ b/lisp/progmodes/flymake.el
> @@ -951,11 +951,13 @@ flymake--mode-line-format
> keymap
> ,(let ((map (make-sparse-keymap))
> (type type))
> - (define-key map [mode-line mouse-4]
> + (define-key map (vector 'mode-line
> + mouse-wheel-down-event)
> (lambda (_event)
> (interactive "e")
> (flymake-goto-prev-error 1 (list type) t)))
> - (define-key map [mode-line mouse-5]
> + (define-key map (vector 'mode-line
> + mouse-wheel-up-event)
> (lambda (_event)
> (interactive "e")
> (flymake-goto-next-error 1 (list type) t)))
> @@ -967,7 +969,9 @@ flymake--mode-line-format
> 'face face)
> (propertize (format "%s" type)
> 'face face))
> - "mouse-4/mouse-5: previous/next of this type\n"))
> + (format "%s/%s: previous/next of this type"
> + mouse-wheel-down-event
> + mouse-wheel-up-event)))
> into forms
> finally return
> `((:propertize "[")
next prev parent reply other threads:[~2018-02-26 21:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 15:31 bug#28732: flymake mouse-wheel portability fix Charles A. Roelli
2017-10-21 13:06 ` Charles A. Roelli
2018-02-26 21:38 ` Glenn Morris [this message]
2018-02-27 19:28 ` Charles A. Roelli
2018-02-27 19:31 ` Eli Zaretskii
2018-02-28 19:02 ` Charles A. Roelli
2018-02-28 20:32 ` Eli Zaretskii
2018-03-01 19:43 ` Charles A. Roelli
2018-03-02 2:10 ` Noam Postavsky
2018-03-03 10:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=k4fu5n5t3p.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=28732@debbugs.gnu.org \
--cc=charles@aurox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).