bug#72575: [PATCH-scratch/igc] Fix gcc-8 compile error

bug#72575: [PATCH-scratch/igc] Fix gcc-8 compile error

[Yikai Zhao]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

Tags: patch


This is a patch for scratch/igc branch.

Before this commit, with MPS and X11 enabled, gcc-8 would fail to
compile complaining "label at end of compound statement"


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-gcc-8-compile-error.patch --]
[-- Type: text/patch, Size: 717 bytes --]

From dd24e92fab736596c5b65245a083a9c6b8e2edd2 Mon Sep 17 00:00:00 2001
From: Yikai Zhao <yikai@z1k.dev>
Date: Sun, 11 Aug 2024 20:53:13 +0800
Subject: [PATCH] ; Fix gcc-8 compile error

Before this commit, with MPS and X11 enabled, gcc-8 would fail to
compile complaining "label at end of compound statement"
---
 src/xfaces.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/xfaces.c b/src/xfaces.c
index 69d4070b603..e3b5e867462 100644
--- a/src/xfaces.c
+++ b/src/xfaces.c
@@ -4642,6 +4642,7 @@ free_realized_face (struct frame *f, struct face *face)
 #ifndef HAVE_MPS
       xfree (face);
 #endif
+      (void)0;  /* prevent the above label being the end of a compound statement */
     }
 }
 
-- 
2.44.2

bug#72575: [PATCH-scratch/igc] Fix gcc-8 compile error

[Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On Sunday, August 11th, 2024 at 13:12, Yikai Zhao <yikai@z1k.dev> wrote:
> Tags: patch
>
> This is a patch for scratch/igc branch.
>
> Before this commit, with MPS and X11 enabled, gcc-8 would fail to
> compile complaining "label at end of compound statement"

Thank you! Applied and pushed.

I don't know whether you have signed the copyright paperwork, but this change should be exempt in any case.

Thanks for testing this branch! I hope it works for you and would love to hear about any experiences.

(My apologies if you receive this twice, my mail agent was acting up).

Pip

bug#72575: [PATCH-scratch/igc] Fix gcc-8 compile error

[Andrea Corallo]

Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs@gnu.org> writes:

> On Sunday, August 11th, 2024 at 13:12, Yikai Zhao <yikai@z1k.dev> wrote:
>> Tags: patch
>>
>> This is a patch for scratch/igc branch.
>>
>> Before this commit, with MPS and X11 enabled, gcc-8 would fail to
>> compile complaining "label at end of compound statement"
>
> Thank you! Applied and pushed.
>
> I don't know whether you have signed the copyright paperwork,

He did, you see it by looking at his previous commits with no copyright
exempt or ask maitainers.

Thanks

  Andrea

bug#72575: [PATCH-scratch/igc] Fix gcc-8 compile error

[Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors]

"Andrea Corallo" <acorallo@gnu.org> writes:

> Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text
> editors" <bug-gnu-emacs@gnu.org> writes:
>
>> On Sunday, August 11th, 2024 at 13:12, Yikai Zhao <yikai@z1k.dev> wrote:
>>> Tags: patch
>>>
>>> This is a patch for scratch/igc branch.
>>>
>>> Before this commit, with MPS and X11 enabled, gcc-8 would fail to
>>> compile complaining "label at end of compound statement"
>>
>> Thank you! Applied and pushed.
>>
>> I don't know whether you have signed the copyright paperwork,
>
> He did, you see it by looking at his previous commits with no copyright
> exempt or ask maitainers.

Thank you for that advice, I'll make sure to do that in future.

Pip