From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#1434: Docstring for `toggle-read-only' shouldn't imply the buffer is file-visiting Date: Wed, 03 Dec 2008 18:58:28 -0500 Message-ID: References: Reply-To: Glenn Morris , 1434@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1228349484 8191 80.91.229.12 (4 Dec 2008 00:11:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Dec 2008 00:11:24 +0000 (UTC) Cc: 1434@emacsbugs.donarmstrong.com To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 04 01:12:27 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L81pM-0005Th-GD for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Dec 2008 01:12:20 +0100 Original-Received: from localhost ([127.0.0.1]:45973 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L81oB-0007KZ-Op for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Dec 2008 19:11:07 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L81nN-0006wi-L5 for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 19:10:17 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L81nM-0006w5-Mp for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 19:10:17 -0500 Original-Received: from [199.232.76.173] (port=43486 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L81nM-0006vs-Hg for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 19:10:16 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:53135) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L81nM-0006ex-0w for bug-gnu-emacs@gnu.org; Wed, 03 Dec 2008 19:10:16 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB40AD0M029414; Wed, 3 Dec 2008 16:10:13 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mB4055a4027584; Wed, 3 Dec 2008 16:05:05 -0800 X-Loop: don@donarmstrong.com Resent-From: Glenn Morris Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 04 Dec 2008 00:05:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1434 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1434-submit@emacsbugs.donarmstrong.com id=B1434.122834874025488 (code B ref 1434); Thu, 04 Dec 2008 00:05:05 +0000 Original-Received: (at 1434) by emacsbugs.donarmstrong.com; 3 Dec 2008 23:59:00 +0000 Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB3NwvsY025482 for <1434@emacsbugs.donarmstrong.com>; Wed, 3 Dec 2008 15:58:58 -0800 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1L81bw-0006sW-HK; Wed, 03 Dec 2008 18:58:28 -0500 X-Spook: Juiliett Class Submarine Al Jazeera ASDIC Plame Delta X-Ran: q!p^7tzH@EW1>,;mNhSxF[R0ybRrQezyBi+`Qq@uXlMz_k5&ILR&H)z$W^O%;kV'aT^9Rn X-Hue: cyan X-Attribution: GM In-Reply-To: (Juanma Barranquero's message of "Wed, 26 Nov 2008 16:37:31 +0100") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 03 Dec 2008 19:10:17 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22930 Archived-At: "Juanma Barranquero" wrote: > `toggle-read-only' is useful for non-visiting buffers too, though > the docstring seems to imply otherwise. So let's change it? *** files.el 3 Dec 2008 03:26:01 -0000 1.1022 --- files.el 3 Dec 2008 23:57:40 -0000 *************** *** 4404,4412 **** (set-buffer-modified-p arg)) (defun toggle-read-only (&optional arg) ! "Change whether this buffer is visiting its file read-only. With prefix argument ARG, make the buffer read-only if ARG is ! positive, otherwise make it writable. If visiting file read-only and `view-read-only' is non-nil, enter view mode." (interactive "P") (if (and arg --- 4404,4412 ---- (set-buffer-modified-p arg)) (defun toggle-read-only (&optional arg) ! "Change whether this buffer is read-only. With prefix argument ARG, make the buffer read-only if ARG is ! positive, otherwise make it writable. If buffer is read-only and `view-read-only' is non-nil, enter view mode." (interactive "P") (if (and arg