From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4179: vc-merge with svn: syntax error in revision arg. Date: Tue, 25 Aug 2009 14:06:58 -0400 Message-ID: References: <87my5ycpj3.fsf@urmel.duenenhof-wilhelm.de> <200908200259.n7K2x8sj004573@godzilla.ics.uci.edu> Reply-To: Stefan Monnier , 4179@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1251224834 14866 80.91.229.12 (25 Aug 2009 18:27:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Aug 2009 18:27:14 +0000 (UTC) Cc: Dieter Wilhelm , 4179@emacsbugs.donarmstrong.com To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 25 20:27:06 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mg0jZ-0007wE-S1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Aug 2009 20:27:06 +0200 Original-Received: from localhost ([127.0.0.1]:45321 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mg0jZ-0003Y2-3I for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Aug 2009 14:27:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mg0jT-0003WR-Kj for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2009 14:26:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mg0jP-0003SR-P0 for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2009 14:26:59 -0400 Original-Received: from [199.232.76.173] (port=50032 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mg0jP-0003SJ-LQ for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2009 14:26:55 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:58603) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mg0jP-0002LF-6e for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2009 14:26:55 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7PIQqVe008727; Tue, 25 Aug 2009 11:26:53 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7PIF5tf006940; Tue, 25 Aug 2009 11:15:05 -0700 Resent-Date: Tue, 25 Aug 2009 11:15:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Tue, 25 Aug 2009 18:15:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4179 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4179-submit@emacsbugs.donarmstrong.com id=B4179.12512236245761 (code B ref 4179); Tue, 25 Aug 2009 18:15:05 +0000 Original-Received: (at 4179) by emacsbugs.donarmstrong.com; 25 Aug 2009 18:07:04 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from pruche.dit.umontreal.ca (pruche.dit.umontreal.ca [132.204.246.22]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7PI720j005752 for <4179@emacsbugs.donarmstrong.com>; Tue, 25 Aug 2009 11:07:03 -0700 Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n7PI6wq0029092; Tue, 25 Aug 2009 14:06:58 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 7ADE73A06B; Tue, 25 Aug 2009 14:06:58 -0400 (EDT) In-Reply-To: <200908200259.n7K2x8sj004573@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 19 Aug 2009 19:59:08 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3348=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Tue, 25 Aug 2009 14:26:59 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30558 Archived-At: > Stefan, how would you go about making these functions backend specific: > (defun vc-trunk-p (rev) > (defun vc-branch-p (rev) > (defun vc-branch-part (rev) > (defun vc-minor-part (rev) Not sure: for some backends (svn, bzr, darcs at least), they simply don't make any sense. > It seems to me that only `vc-branch-p' needs to be backend specific, the > rest are only used by RCS and CVS. That sounds right. > vc-default-{previous,next}-revision use them, but they can go into > vc-rcs (or vc-cvs) and make one use the other (there's a precedent, > vc-cvs-comment-history uses an RCS backend function...). > Do you see an elegant way of dealing with this? Move them to vc-rcs. Stefan