From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo <sdl.web@gmail.com>
Cc: 6881@debbugs.gnu.org
Subject: bug#6881: 23.2; bookmark-bmenu-search makes menu disappear
Date: Thu, 19 Aug 2010 16:47:58 +0200 [thread overview]
Message-ID: <jwvzkwizogu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m1y6c384d1.fsf@cam.ac.uk> (Leo's message of "Thu, 19 Aug 2010 08:10:34 +0100")
> This is a bug in read-key.
> It appears using read-char solve this problem and the key echoing one.
I strongly encourage people to switch from read-char to read-key, so if
there's a problem with read-key, I'd rather try and fix it rather than
return to read-char.
I've just installed the patch below into emacs-23 which should fix it.
Stefan
=== modified file 'lisp/subr.el'
--- lisp/subr.el 2010-07-10 18:52:53 +0000
+++ lisp/subr.el 2010-08-19 14:25:12 +0000
@@ -1842,7 +1842,12 @@
(throw 'read-key keys)))))))
(unwind-protect
(progn
- (use-global-map read-key-empty-map)
+ (use-global-map
+ (let ((map (make-sparse-keymap)))
+ ;; Don't hide the menu-bar and tool-bar entries.
+ (define-key map [menu-bar] (lookup-key global-map [menu-bar]))
+ (define-key map [tool-bar] (lookup-key global-map [tool-bar]))
+ map))
(aref (catch 'read-key (read-key-sequence-vector prompt nil t)) 0))
(cancel-timer timer)
(use-global-map old-global-map))))
next prev parent reply other threads:[~2010-08-19 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 18:00 bug#6881: 23.2; bookmark-bmenu-search makes menu disappear Leo
2010-08-19 7:10 ` Leo
2010-08-19 9:22 ` Thierry Volpiatto
2010-08-19 14:47 ` Stefan Monnier [this message]
2010-08-19 15:21 ` Leo
2010-08-19 15:30 ` Thierry Volpiatto
2010-08-19 21:37 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzkwizogu.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=6881@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).