unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Bob Rogers <rogers-emacs@rgrjr.dyndns.org>
Cc: 7675@debbugs.gnu.org
Subject: bug#7675: 24.0.50; vc-checkin should prompt if the fileset changes
Date: Sun, 19 Dec 2010 08:57:00 -0500	[thread overview]
Message-ID: <jwvzks1rhnl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <19725.10211.399667.389809@rgr.rgrjr.com> (Bob Rogers's message of "Sat, 18 Dec 2010 16:30:11 -0500")

Thanks for submitting a patch to try and fix this problem.
A quick obvious issue, tho:

> --- a/lisp/vc/vc.el
> +++ b/lisp/vc/vc.el
[...]
> +(defun log-edit-deduce-fileset (state-model-only-files)

If it's in vc.el it can't start with the "log-edit-" prefix.


        Stefan "who hasn't yet had time to look at the rest of the patch"





  parent reply	other threads:[~2010-12-19 13:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-18 21:30 bug#7675: 24.0.50; vc-checkin should prompt if the fileset changes Bob Rogers
     [not found] ` <handler.7675.B.129270743922452.ack@debbugs.gnu.org>
2010-12-19  4:45   ` Bob Rogers
2010-12-19 13:57 ` Stefan Monnier [this message]
2010-12-19 20:45   ` Bob Rogers
2010-12-20  2:50     ` Stefan Monnier
2010-12-20  4:17       ` Bob Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzks1rhnl.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=7675@debbugs.gnu.org \
    --cc=rogers-emacs@rgrjr.dyndns.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).