unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Vincent Lefevre <vincent@vinc17.net>
Cc: wd <wd@wdicc.com>, 10095-done@debbugs.gnu.org
Subject: bug#10095: 24.0.50; cperl-mode highlight bug
Date: Mon, 06 Aug 2012 13:41:52 -0400	[thread overview]
Message-ID: <jwvzk67ncnd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwvmx28oxay.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 06 Aug 2012 11:48:38 -0400")

Version: 24.2

>> It still exists in GNU Emacs 24.1.1. I actually noticed the problem
>> on the following code, and I believe it's the same bug. It seems
>> that CPerl doesn't detect the end of a long qq or qw.
> Thanks for the test case, I can reproduce it here with the trunk, so
> it's not yet fixed.

I've just installed the patch below in the `emacs-24' branch.  I believe
it fixes your problem.  Thanks for the good test case,


        Stefan


=== modified file 'lisp/progmodes/cperl-mode.el'
--- lisp/progmodes/cperl-mode.el	2012-07-18 09:33:09 +0000
+++ lisp/progmodes/cperl-mode.el	2012-08-06 17:20:25 +0000
@@ -1838,7 +1838,13 @@
             (set (make-local-variable 'cperl-syntax-done-to) nil)
             (set (make-local-variable 'syntax-propertize-function)
                  (lambda (start end)
-                   (goto-char start) (cperl-fontify-syntaxically end))))
+                   (goto-char start)
+                   ;; Even if cperl-fontify-syntaxically has already gone
+                   ;; beyond `start', syntax-propertize has just removed
+                   ;; syntax-table properties between start and end, so we have
+                   ;; to re-apply them.
+                   (setq cperl-syntax-done-to start)
+                   (cperl-fontify-syntaxically end))))
 	(make-local-variable 'parse-sexp-lookup-properties)
 	;; Do not introduce variable if not needed, we check it!
 	(set 'parse-sexp-lookup-properties t)






      reply	other threads:[~2012-08-06 17:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 10:10 bug#10095: 24.0.50; cperl-mode highlight bug wd
2012-04-02 19:37 ` wd
2012-04-27  9:29   ` wd
2012-07-11 11:59     ` Vincent Lefevre
2012-08-06 15:48       ` Stefan Monnier
2012-08-06 17:41         ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzk67ncnd.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=10095-done@debbugs.gnu.org \
    --cc=vincent@vinc17.net \
    --cc=wd@wdicc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).