From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13523: 24.2.92; [regression] mark-active Date: Wed, 30 Jan 2013 21:47:11 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1359600447 18835 80.91.229.3 (31 Jan 2013 02:47:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Jan 2013 02:47:27 +0000 (UTC) Cc: 13523@debbugs.gnu.org, Chong Yidong To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 31 03:47:46 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U0kBl-00048l-01 for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Jan 2013 03:47:45 +0100 Original-Received: from localhost ([::1]:35259 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0kBS-0003fs-P5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Jan 2013 21:47:26 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0kBP-0003fc-ER for bug-gnu-emacs@gnu.org; Wed, 30 Jan 2013 21:47:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U0kBO-0007LV-Dx for bug-gnu-emacs@gnu.org; Wed, 30 Jan 2013 21:47:23 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0kBO-0007LQ-AV for bug-gnu-emacs@gnu.org; Wed, 30 Jan 2013 21:47:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U0kC1-0006w3-HI for bug-gnu-emacs@gnu.org; Wed, 30 Jan 2013 21:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Jan 2013 02:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed help Original-Received: via spool by 13523-submit@debbugs.gnu.org id=B13523.135960047326643 (code B ref 13523); Thu, 31 Jan 2013 02:48:01 +0000 Original-Received: (at 13523) by debbugs.gnu.org; 31 Jan 2013 02:47:53 +0000 Original-Received: from localhost ([127.0.0.1]:56527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0kBt-0006vf-BU for submit@debbugs.gnu.org; Wed, 30 Jan 2013 21:47:53 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:21850) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U0kBs-0006vZ-29 for 13523@debbugs.gnu.org; Wed, 30 Jan 2013 21:47:52 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFG4rw3e/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av8EABK/CFG4rw3e/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="82172" Original-Received: from 184-175-13-222.dsl.teksavvy.com (HELO ceviche.home) ([184.175.13.222]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 30 Jan 2013 21:47:11 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 4A7D866130; Wed, 30 Jan 2013 21:47:11 -0500 (EST) In-Reply-To: (Glenn Morris's message of "Tue, 29 Jan 2013 21:00:42 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70514 Archived-At: > Can we turn the test around, so that rather than saying "deactivate the > mark if the final event was mouse-set-point or mouse-set-region", we say > "deactivate the mark unless the final event was X or Y"? > (I don't know what X or Y are, something related to multi-clicks I guess.) Can someone point out why the patch below wouldn't work? Stefan === modified file 'lisp/mouse.el' --- lisp/mouse.el 2013-01-30 17:14:24 +0000 +++ lisp/mouse.el 2013-01-31 02:45:05 +0000 @@ -880,9 +880,9 @@ (copy-region-as-kill (mark) (point))))) ;; Otherwise, run binding of terminating up-event. + (deactivate-mark) (if do-multi-click (goto-char start-point) - (deactivate-mark) (unless moved-off-start (pop-mark)))