From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#3984: Date: Thu, 19 Sep 2013 16:59:38 -0400 Message-ID: References: <20E00C7675E64356BF2F0B2A7E0ABDB1@us.oracle.com> <5232D333.8030206@thompsonclan.org> <523359CD.2070904@thompsonclan.org> <5233670E.4030703@thompsonclan.org> <5237C9FF.1000809@thompsonclan.org> <52388FEB.6020007@thompsonclan.org> <523A37A4.5060505@thompsonclan.org> <523A49BE.3060109@thompsonclan.org> <523AB06B.9090606@thompsonclan.org> <523B4F4E.3060204@thompsonclan.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: ger.gmane.org 1380073224 5732 80.91.229.3 (25 Sep 2013 01:40:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Sep 2013 01:40:24 +0000 (UTC) Cc: 3984@debbugs.gnu.org To: Ryan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 25 03:40:26 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VOe5Z-0005EA-0B for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Sep 2013 03:40:25 +0200 Original-Received: from localhost ([::1]:49080 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOe5Y-0008Of-Hv for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Sep 2013 21:40:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOe5M-0008GN-NO for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2013 21:40:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOe5E-0004KC-0h for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2013 21:40:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOe5D-0004IU-Ue for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2013 21:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VOe5D-0007MV-1P for bug-gnu-emacs@gnu.org; Tue, 24 Sep 2013 21:40:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Sep 2013 01:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3984 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3984-submit@debbugs.gnu.org id=B3984.138007320228294 (code B ref 3984); Wed, 25 Sep 2013 01:40:02 +0000 Original-Received: (at 3984) by debbugs.gnu.org; 25 Sep 2013 01:40:02 +0000 Original-Received: from localhost ([127.0.0.1]:33711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOe5B-0007MC-38 for submit@debbugs.gnu.org; Tue, 24 Sep 2013 21:40:01 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:19997) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOe57-0007M1-T4 for 3984@debbugs.gnu.org; Tue, 24 Sep 2013 21:39:59 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFG4rw0Z/2dsb2JhbABEvw4Xc4IfAQU6AgEZIxALNBIUGA0kiCTBLZEKA6R6gV6DEw X-IPAS-Result: Av4EABK/CFG4rw0Z/2dsb2JhbABEvw4Xc4IfAQU6AgEZIxALNBIUGA0kiCTBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="28975209" Original-Received: from 184-175-13-25.dsl.teksavvy.com (HELO pastel.home) ([184.175.13.25]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 24 Sep 2013 21:35:43 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id B9E046327D; Tue, 24 Sep 2013 21:39:55 -0400 (EDT) Resent-Message-ID: Resent-To: 3984@debbugs.gnu.org Resent-From: Stefan Monnier Resent-Date: Tue, 24 Sep 2013 21:39:55 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id D95C5662B9; Thu, 19 Sep 2013 16:59:38 -0400 (EDT) In-reply-to: <523B4F4E.3060204@thompsonclan.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78724 Archived-At: > "advice-test-called-interactively-p" test in test/automated/advice-tests.el > happens to pass, but only because it doesn't use "called-interactively-p" > inside the original function, but rather only inside the advice > itself. Indeed. And it a very important case: the main definition of a function can be modified to not use called-interactively-p (add an argument which is set to a non-nil value in the interactive spec), but that's not really an option for an advice that requires to know if the function was called interactively (strictly speaking, it can be done, but it's a lot more trouble). Stefan