From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.bugs Subject: bug#16762: Installed packages are not considered part of the archive contents Date: Sun, 23 Mar 2014 20:55:58 -0400 Message-ID: References: <87lhw4nj42.fsf@yandex.ru> <532CC639.6000309@yandex.ru> <532E9868.60207@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1395622637 16102 80.91.229.3 (24 Mar 2014 00:57:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Mar 2014 00:57:17 +0000 (UTC) Cc: Johan Andersson , 16762@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 24 01:57:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WRtCd-00036H-DM for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Mar 2014 01:57:23 +0100 Original-Received: from localhost ([::1]:34018 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRtCd-0007aj-4e for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Mar 2014 20:57:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRtCQ-0007NG-CK for bug-gnu-emacs@gnu.org; Sun, 23 Mar 2014 20:57:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WRtCJ-0003Y5-3O for bug-gnu-emacs@gnu.org; Sun, 23 Mar 2014 20:57:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRtCJ-0003Xt-0J for bug-gnu-emacs@gnu.org; Sun, 23 Mar 2014 20:57:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WRtCI-0002Kl-CN for bug-gnu-emacs@gnu.org; Sun, 23 Mar 2014 20:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Mar 2014 00:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16762 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16762-submit@debbugs.gnu.org id=B16762.13956225658898 (code B ref 16762); Mon, 24 Mar 2014 00:57:02 +0000 Original-Received: (at 16762) by debbugs.gnu.org; 24 Mar 2014 00:56:05 +0000 Original-Received: from localhost ([127.0.0.1]:46454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WRtBM-0002JS-NY for submit@debbugs.gnu.org; Sun, 23 Mar 2014 20:56:04 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:54151) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WRtBK-0002J0-F9 for 16762@debbugs.gnu.org; Sun, 23 Mar 2014 20:56:03 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s2O0twc4016797; Sun, 23 Mar 2014 20:55:59 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id A5AAF6017C; Sun, 23 Mar 2014 20:55:58 -0400 (EDT) In-Reply-To: <532E9868.60207@yandex.ru> (Dmitry Gutov's message of "Sun, 23 Mar 2014 10:16:40 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4890=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4890> : inlines <634> : streams <1143601> : uri <1708025> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87276 Archived-At: >> Yes, but as long as we don't know why this was done, it's too risky to >> change it. If/when we figure out what that was about and come up with >> a way to fix the problem, we can judge whether that's appropriate for >> 24.4. > From what I can see, except `package-install', all places where > `package-archive-contents' is used, either append its contents to > `package-alist' elements, or use a predicate calling `package-installed-p'. > The following patch seems to offer the same functionality: Does it affect the output of M-x package-list RET? What about the package-menu-mark-upgrades? > (cond > - ;; Skip entirely if pinned to another archive or already installed. > + ;; Skip entirely if pinned to another archive or built-in. > ((or (and pinned-to-archive > (not (equal (cdr pinned-to-archive) archive))) > (let ((bi (assq name package--builtin-versions))) > - (and bi (version-list-= version (cdr bi)))) > - (let ((ins (cdr (assq name package-alist)))) > - (and ins (version-list-= version > - (package-desc-version (car ins)))))) > + (and bi (version-list-= version (cdr bi))))) > nil) If we can keep the already installed packages, couldn't we also keep the already built-in packages? Stefan