From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20322: 25.0.50; indent-tabs-mode should default to nil Date: Tue, 14 Apr 2015 21:19:06 -0400 Message-ID: References: <861tjn3069.fsf@yandex.ru> <552D20B6.8030005@yandex.ru> <83mw2abul3.fsf@gnu.org> <552D34BC.4090806@yandex.ru> <83h9sibt0q.fsf@gnu.org> <552D7796.2090109@yandex.ru> <552D9204.3000604@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1429060822 31450 80.91.229.3 (15 Apr 2015 01:20:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Apr 2015 01:20:22 +0000 (UTC) Cc: 20322@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 15 03:20:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YiBzw-00056O-P7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Apr 2015 03:20:12 +0200 Original-Received: from localhost ([::1]:58426 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiBzv-0000WQ-KG for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Apr 2015 21:20:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiBzs-0000Uw-C6 for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2015 21:20:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YiBzp-0000Sg-2x for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2015 21:20:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiBzp-0000RN-0O for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2015 21:20:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YiBzn-0003EZ-Uf for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2015 21:20:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Apr 2015 01:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20322 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20322-submit@debbugs.gnu.org id=B20322.142906076012377 (code B ref 20322); Wed, 15 Apr 2015 01:20:03 +0000 Original-Received: (at 20322) by debbugs.gnu.org; 15 Apr 2015 01:19:20 +0000 Original-Received: from localhost ([127.0.0.1]:56525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YiBz6-0003DZ-Cf for submit@debbugs.gnu.org; Tue, 14 Apr 2015 21:19:20 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:45260) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YiByu-0003DH-J7 for 20322@debbugs.gnu.org; Tue, 14 Apr 2015 21:19:18 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3F1J6Xg012035; Tue, 14 Apr 2015 21:19:06 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 4C20B1E7F; Tue, 14 Apr 2015 21:19:06 -0400 (EDT) In-Reply-To: <552D9204.3000604@yandex.ru> (Dmitry Gutov's message of "Wed, 15 Apr 2015 01:17:40 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5276=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5276> : inlines <2715> : streams <1422614> : uri <1906938> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101542 Archived-At: > However, the implementation seems to do the right thing: > https://github.com/outsideris/popularconvention/blob/master/src/parser/js-parser.coffee#L99-L100 This seems to count the number of lines which start with a SPC and those which start with a TAB. If your indentation rules use an indentation step of 2, you'd likely get many more lines that start with SPC regardless of indent-tabs-mode (just because most lines of code are less indented than 8 columns). So, I don't think it does the right test. I think the right test would be tab = /^\t/ space = /^\s\s\s\s\s\s\s\s/ -- Stefan