From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23632: 25.1.50; Gratuitous undo boundary in latex-insert-block Date: Sat, 04 Jun 2016 12:49:50 -0400 Message-ID: References: <87lh2vo7s6.fsf@gmail.com> <87shx23830.fsf@gmail.com> <87wpmcwn13.fsf@russet.org.uk> <87wpm9q4z7.fsf@russet.org.uk> <87vb1rbbg1.fsf@russet.org.uk> <87shwutfmo.fsf@russet.org.uk> <87porxrk4v.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1465059093 14975 80.91.229.3 (4 Jun 2016 16:51:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 4 Jun 2016 16:51:33 +0000 (UTC) Cc: Chong Yidong , 23632@debbugs.gnu.org To: "Phillip Lord" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 04 18:51:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b9En2-0000Wv-GH for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Jun 2016 18:51:12 +0200 Original-Received: from localhost ([::1]:33415 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9En1-0005oU-Ks for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Jun 2016 12:51:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9Emw-0005nE-BN for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2016 12:51:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9Ems-0007Gm-9s for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2016 12:51:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9Ems-0007Gh-6a for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2016 12:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b9Emr-00018b-SW for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2016 12:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jun 2016 16:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23632-submit@debbugs.gnu.org id=B23632.14650590054307 (code B ref 23632); Sat, 04 Jun 2016 16:51:01 +0000 Original-Received: (at 23632) by debbugs.gnu.org; 4 Jun 2016 16:50:05 +0000 Original-Received: from localhost ([127.0.0.1]:54562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9Elr-00016u-Vx for submit@debbugs.gnu.org; Sat, 04 Jun 2016 12:50:05 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:12538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9Elq-00016h-AA for 23632@debbugs.gnu.org; Sat, 04 Jun 2016 12:49:58 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DGEQA731xV//qVSC1cgxCEAoVVu0CEfoJTAoE9OhIBAQEBAQEBgQpBBYNdAQEDAXkFCwsNJxIUGDEsiAsIzyMBAQEBAQUCAR+LOoUFB4QtBYUJlluKEY8PI4QUIoJ4AQEB X-IPAS-Result: A0DGEQA731xV//qVSC1cgxCEAoVVu0CEfoJTAoE9OhIBAQEBAQEBgQpBBYNdAQEDAXkFCwsNJxIUGDEsiAsIzyMBAQEBAQUCAR+LOoUFB4QtBYUJlluKEY8PI4QUIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="240432523" Original-Received: from unknown (HELO pastel.home) ([45.72.149.250]) by ironport2-out.teksavvy.com with ESMTP; 04 Jun 2016 12:49:50 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 48BAE63FFB; Sat, 4 Jun 2016 12:49:50 -0400 (EDT) In-Reply-To: (Phillip Lord's message of "Sat, 4 Jun 2016 09:51:15 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119066 Archived-At: > Yes. This is assuming that commands *both* change recursion depth *and* > change a buffer. Yes, it's like a fairly rare occurrence, where a command does both: - modify some buffer(s) - exit a recursive edit So maybe we can live without paying attention to it. >>> -- once when we capture the undoable changes (which happens >>> often) and once on at the end of each command. >> Right. I see no need for any changes there. > Really? I have to know the recursion depth at this point No, let-bind the var to nil around each recursive edit should take care of "everything" so you don't need to change anything else (including, non need to pay any attention to the recursion depth). > To be clear, though, to do this I need to augment recursive-edit in C? I > need the let binding to last the life of the recursive edit? That's right. A call to `specbind' at the right spot might even be all it takes. Stefan