From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template =?UTF-8?Q?=E2=80=98g=E2=80=99:?= Match data clobbered by buffer modification hooks) Date: Tue, 19 Jul 2016 12:03:51 -0400 Message-ID: References: <87vb066ejv.fsf@linaro.org> <8360s67qcp.fsf@gnu.org> <87bn1yyaui.fsf@linaro.org> <87mvlhmv0x.fsf_-_@moondust.awandering> <837fcl5zs9.fsf@gnu.org> <87a8hgkwcb.fsf@linaro.org> <8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com> <83lh0y24y6.fsf@gnu.org> <83eg6q1hbo.fsf@gnu.org> <83a8hd1vzi.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468944345 2155 80.91.229.3 (19 Jul 2016 16:05:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Jul 2016 16:05:45 +0000 (UTC) Cc: 23917@debbugs.gnu.org, rpluim@gmail.com, jwiegley@gmail.com, alex.bennee@linaro.org, nljlistbox2@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 19 18:05:28 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPXWR-00054q-QF for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 18:05:28 +0200 Original-Received: from localhost ([::1]:57031 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPXWQ-0000EI-QX for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 12:05:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPXW8-0008In-Et for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 12:05:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPXW7-0005LD-Cn for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 12:05:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPXW2-0005Ij-JH; Tue, 19 Jul 2016 12:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPXW2-0002ey-AL; Tue, 19 Jul 2016 12:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Tue, 19 Jul 2016 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23917 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 23917-submit@debbugs.gnu.org id=B23917.146894424210151 (code B ref 23917); Tue, 19 Jul 2016 16:05:02 +0000 Original-Received: (at 23917) by debbugs.gnu.org; 19 Jul 2016 16:04:02 +0000 Original-Received: from localhost ([127.0.0.1]:57482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPXV4-0002dd-CB for submit@debbugs.gnu.org; Tue, 19 Jul 2016 12:04:02 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:15645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPXV2-0002dB-RE for 23917@debbugs.gnu.org; Tue, 19 Jul 2016 12:04:01 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AfDgA731xV/3mcpUVcgxCEAgjIWAQCAoE8PRABAQEBAQEBgQpBBYNdAQEDAQxKIwULCQI0BwsUGA0TEYg3CI18wScBAQgCAR+LOoUFB4QtBYZlmDKDa44pghSBRSOBZlWBWSKCeAEBAQ X-IPAS-Result: A0AfDgA731xV/3mcpUVcgxCEAgjIWAQCAoE8PRABAQEBAQEBgQpBBYNdAQEDAQxKIwULCQI0BwsUGA0TEYg3CI18wScBAQgCAR+LOoUFB4QtBYZlmDKDa44pghSBRSOBZlWBWSKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="248549229" Original-Received: from 69-165-156-121.dsl.teksavvy.com (HELO pastel.home) ([69.165.156.121]) by ironport2-out.teksavvy.com with ESMTP; 19 Jul 2016 12:03:52 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id D4FC264C98; Tue, 19 Jul 2016 12:03:51 -0400 (EDT) In-Reply-To: <83a8hd1vzi.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 19 Jul 2016 18:35:45 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121266 Archived-At: > Before call to replace_range in replace-match: > > |---------------------------|---|------|----| > s1 e1 s2 e2 EOB > > (s1, e1, etc. are the start and end of the corresponding > sub-expressions.) > > After the call to replace_range in replace-match: > > |---------|---|------|----| > s1 e1 s2 e2 EOB Ah, right, now I see my confusion, thank you. So, the data is within bounds before replace_range but after bounds afterwards and the subsequent adjustments should fix it, but an intervening save-match-data will mess it up. Hmm... indeed, the adjustment isn't working correctly in this case. I don't think we can safely change the way save-match-data works, so I guess the next best thing is: - copy search_regs.start and search_regs.end before calling replace_range. - use that copy when adjusting the match data. Or equivalently, use save-match-data. IOW go back to your original patch. Duh! Stefan