unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: michael_heerdegen@web.de, 29422@debbugs.gnu.org
Subject: bug#29422: 27.0.50; Symbol enable-multibyte-characters may not be buffer-local
Date: Sat, 25 Nov 2017 21:07:22 -0500	[thread overview]
Message-ID: <jwvzi79pzf0.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <834lpi8eek.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Nov 2017 19:19:15 +0200")

>> > Yes, but signaling "Setting constant" when we actually mean a
>> > read-only symbol is sub-optimal, IMO.
>> That's the error that we've been using for (setq
>> enable-multibyte-characters ...) since Emacs-21.

> ??? The code you changed signaled a "Symbol %s may not be
> buffer-local" error, not "Setting constant".  What am I missing?

My patch did not touch `setq`.  It just made `make-local-variable` and
`make-buffer-local-variable` signal the same error as `setq`.

> I meant for you to do that, as part of fixing this problem, but if you
> don't feel like it, we should at least change the ELisp manual, as it
> now contradicts the code.

If you mean the doc of `setq`, then I guess this discrepancy has been
with us since Emacs-21.


        Stefan





  reply	other threads:[~2017-11-26  2:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-24  7:56 bug#29422: 27.0.50; Symbol enable-multibyte-characters may not be buffer-local Michael Heerdegen
2017-11-25  1:22 ` Michael Heerdegen
2017-11-25  7:53   ` Eli Zaretskii
2017-11-25 16:47     ` Stefan Monnier
2017-11-25 17:19       ` Eli Zaretskii
2017-11-26  2:07         ` Stefan Monnier [this message]
2017-11-26  3:39           ` Eli Zaretskii
2017-11-26 15:31           ` Eli Zaretskii
2017-11-27  4:42             ` bug#29422: [SUSPECTED SPAM] " Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzi79pzf0.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=29422@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).