unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: 29956@debbugs.gnu.org
Subject: bug#29956: 26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47
Date: Tue, 02 Jan 2018 22:50:52 -0500	[thread overview]
Message-ID: <jwvzi5vy50j.fsf@iro.umontreal.ca> (raw)

Package: Emacs
Version: 26.0.90


    % src/emacs -Q lisp/emacs-lisp/pcase.el
    ...Select the first (def-edebug-spec ...)
    C-x v h
    In the *VC-history* buffer, hit `d'

This gives me `Wrong type argument: sequencep, 47'
[ Which file you use, and which region of the file you select doesn't
  really matter.  ]

The patch below fixes it for me.

Is it OK to install it into emacs-26, or should I keep it on `master`?

FWIW, it's not a new bug in Emacs-26 and it's not terribly urgent to fix
it, e.g. because you can use `D' which does work (tho it doesn't do
quite the same), so I'm fine with either choice.


        Stefan


diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index 7c502f88df..0a87e70017 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -2426,9 +2426,11 @@ vc-region-history
       (setq-local vc-log-view-type 'long))
     (vc-call region-history file buf lfrom lto)
     (with-current-buffer buf
+      (setq default-directory (file-name-directory file))
       (vc-call-backend backend 'region-history-mode)
       (set (make-local-variable 'log-view-vc-backend) backend)
-      (set (make-local-variable 'log-view-vc-fileset) file)
+      (set (make-local-variable 'log-view-vc-fileset)
+           (list (file-relative-name file)))
       (set (make-local-variable 'revert-buffer-function)
 	   (lambda (_ignore-auto _noconfirm)
              (with-current-buffer buf





             reply	other threads:[~2018-01-03  3:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03  3:50 Stefan Monnier [this message]
2018-01-03 15:06 ` bug#29956: 26.0.90; `d' in *VC-history*: Wrong type argument: sequencep, 47 Eli Zaretskii
2018-01-03 20:30   ` Stefan Monnier
2018-01-03 20:35   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzi5vy50j.fsf@iro.umontreal.ca \
    --to=monnier@iro.umontreal.ca \
    --cc=29956@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).