From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#38195: 27.0.50; `edebug-remove-instrumentation' doesn't work for adviced functions Date: Sun, 17 Nov 2019 11:04:34 -0500 Message-ID: References: <87mucz98y9.fsf@web.de> <87r22brq3b.fsf@gnus.org> <87eeya9z3z.fsf@web.de> <87imnm4315.fsf@web.de> <87eey9z1mr.fsf@web.de> <87o8xaoe6j.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="238283"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 38195@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 17 17:05:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iWN32-000zrL-HP for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2019 17:05:12 +0100 Original-Received: from localhost ([::1]:54450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWN31-0003QC-71 for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2019 11:05:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60522) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWN2t-0003Os-3c for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 11:05:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWN2s-0001Zw-4e for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 11:05:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33591) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWN2s-0001Zo-0a for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 11:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iWN2r-0003U7-Qn for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 11:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Nov 2019 16:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38195 X-GNU-PR-Package: emacs Original-Received: via spool by 38195-submit@debbugs.gnu.org id=B38195.157400668513369 (code B ref 38195); Sun, 17 Nov 2019 16:05:01 +0000 Original-Received: (at 38195) by debbugs.gnu.org; 17 Nov 2019 16:04:45 +0000 Original-Received: from localhost ([127.0.0.1]:42412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWN2b-0003TY-9O for submit@debbugs.gnu.org; Sun, 17 Nov 2019 11:04:45 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWN2Y-0003TK-U9 for 38195@debbugs.gnu.org; Sun, 17 Nov 2019 11:04:43 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3331A449EAD; Sun, 17 Nov 2019 11:04:37 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DC620449E9D; Sun, 17 Nov 2019 11:04:35 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1574006675; bh=AS+axoVWZkwe1Wh+RYdfO3zWTUiQYywS0gx7bsMpx1I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WkF2FmlF+9WNXNyAXzl7QkvDUb0arm/xJQ05If35dJ/YKFVDS6GYJ3hKE18/OeWwI NCDdWekRLmk09NKrVVNbxBe5oxg4M4+EXglRoezBGoVtH+qXU4fgINITJyF55FS+QL VExsoBvr35HHpz8k0nRHlnPnN3o/rTkxahY07jm3y6YyplE96oBVw4UyhqLlo1ViEL SN9Hu9fsu/ohfHBU+TS1wvSKDuhzNgNtEanI2mnuv4fm2MXmbXnyLNZx1Ybu18K5Xm aiL5K2uCPBEWu7NWtr+ykJOh9jmu9CVZaUaBlb0h06H4iQbf/8ygZvwiufR0XiPCY2 FhAkvkA9iY7Og== Original-Received: from pastel (206-248-133-142.dsl.teksavvy.com [206.248.133.142]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9CE6112059A; Sun, 17 Nov 2019 11:04:35 -0500 (EST) In-Reply-To: <87o8xaoe6j.fsf@web.de> (Michael Heerdegen's message of "Sun, 17 Nov 2019 13:55:16 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171807 Archived-At: > + (pcase (symbol-function symbol) > + ((or (and `(macro . ,(and (pred advice--p) ad)) (let was-macro t)) > + (and (pred advice--p) ad (let was-macro nil))) I don't think you need the `advice--p` here since `advice--cd*r` uses the `*` meaning of regexps: "*zero* or more". > + ;; `defalias' takes care of any advises so we can just strip them Actually, you *have* to strip them (otherwise you'd end up copying them). Stefan