From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56682: locked narrowing Date: Tue, 16 Aug 2022 17:42:45 -0400 Message-ID: References: <66bbbb95983414e79637@heytings.org> <83wnb9hadb.fsf@gnu.org> <395454dd-7238-c5d0-e924-2f65a186baa7@yandex.ru> <83r11hh4pm.fsf@gnu.org> <3a1232a17b09ce88af40@heytings.org> <83edxghqg2.fsf@gnu.org> <325f95fd2bcc0b666b0b@heytings.org> <83edxgfi75.fsf@gnu.org> <5e3c3081-f098-8140-c767-b895c32bf30b@yandex.ru> <835yisffil.fsf@gnu.org> <831qtgff78.fsf@gnu.org> <83zgg4dw4y.fsf@gnu.org> <83r11gdrr4.fsf@gnu.org> <325f95fd2b8106ed2d16@heytings.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30033"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56682@debbugs.gnu.org, Eli Zaretskii , dgutov@yandex.ru To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 16 23:43:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oO4L9-0007Z4-KZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Aug 2022 23:43:11 +0200 Original-Received: from localhost ([::1]:50168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oO4L8-0002n4-HC for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Aug 2022 17:43:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oO4L0-0002lw-DG for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2022 17:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oO4L0-0001ks-4s for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2022 17:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oO4Kz-0002M3-UT for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2022 17:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Aug 2022 21:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.16606861759038 (code B ref 56682); Tue, 16 Aug 2022 21:43:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 16 Aug 2022 21:42:55 +0000 Original-Received: from localhost ([127.0.0.1]:48541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO4Kt-0002Li-Cs for submit@debbugs.gnu.org; Tue, 16 Aug 2022 17:42:55 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO4Kr-0002LW-M6 for 56682@debbugs.gnu.org; Tue, 16 Aug 2022 17:42:54 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6325D100138; Tue, 16 Aug 2022 17:42:48 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E233F1000ED; Tue, 16 Aug 2022 17:42:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1660686166; bh=JjWlVg/jRRmIUdlkqFjKohuk3dkmVqllMtN0r8Meszk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PQIdurb1YGDNH/w6khj8yq4NwWDpkxrbAwI+nhoFBy2OfDFLlv7VOmnu/LlLLpEgb YvUUTlIqteRNRsKBoLV7e7sLih3Ckb4XQPTEuhzm1ZVs0NYGcu+06sZVf16rFGJxtD RZJt9y4PcowGDUu8qmmW5GxHadgrjgOXq1YGW7FvemPBcyKn1JIIUUkelO6e2wFRui jkH48+lEbHAmc/+a4UaQsSQKxOb8GUHRHno7mD8ELJ/qjYB8E9+WBwXSIe6hTVOj32 oF2NXqakP3liPMocnzAadbJFn7IYoJ9zOqUGrC6Q9WwyMpRv1ftYLUv3EDQHwNaVkD VaWT0MYCxX+lQ== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BFB971201AF; Tue, 16 Aug 2022 17:42:46 -0400 (EDT) In-Reply-To: <325f95fd2b8106ed2d16@heytings.org> (Gregory Heytings's message of "Tue, 16 Aug 2022 20:23:46 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240013 Archived-At: Gregory Heytings [2022-08-16 20:23:46] wrote: > Another comment: >> diff --git a/nlinum.el b/nlinum.el >> index 4f0e02fef1..3feaaca5c3 100644 >> --- a/nlinum.el >> +++ b/nlinum.el >> @@ -312,7 +312,7 @@ Only works right if point is at BOL." >> (if nlinum-widen >> (save-excursion >> (save-restriction >> - (widen) >> + (REALLY-widen) >> (forward-line 0) ;In case (point-min) was not at BOL. >> (let ((nlinum-widen nil)) >> (nlinum--line-number-at-pos)))) > FWIW, that's not a good example, because it's a bad idea to calculate line > numbers in buffers with long lines or with too many lines: it takes too > much time. In my tests, it works fast enough for pretty large buffers and pretty long lines, so while the above might be too crude, the limits we should use for it should be much lower than `syntax-wholeline-max` and even probably larger than `large-file-warning-threshold`. Stefan