From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51130: 29.0.50; shell completion fails to complete filenames Date: Wed, 14 Sep 2022 10:27:37 -0400 Message-ID: References: <87a67496rq.fsf@gnus.org> <87k0674j4k.fsf@gnus.org> <878rmmb0np.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14775"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51130@debbugs.gnu.org, Carlos Pita To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 14 16:28:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYTNK-0003cU-N6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 16:28:26 +0200 Original-Received: from localhost ([::1]:52580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYTNJ-0005gl-Ly for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 10:28:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYTN2-0005e5-Iq for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 10:28:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38764) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYTMw-00044w-Q5 for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 10:28:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYTMw-0003hj-9K for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 10:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Sep 2022 14:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 51130-submit@debbugs.gnu.org id=B51130.166316566914219 (code B ref 51130); Wed, 14 Sep 2022 14:28:02 +0000 Original-Received: (at 51130) by debbugs.gnu.org; 14 Sep 2022 14:27:49 +0000 Original-Received: from localhost ([127.0.0.1]:55696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYTMi-0003hH-NG for submit@debbugs.gnu.org; Wed, 14 Sep 2022 10:27:49 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYTMg-0003h2-2P for 51130@debbugs.gnu.org; Wed, 14 Sep 2022 10:27:47 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 41893807A5; Wed, 14 Sep 2022 10:27:40 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9F57D804BD; Wed, 14 Sep 2022 10:27:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1663165658; bh=vQHlYMiRYQ9spX9KG1q5cQBi68dH0IE4LOcrgqmARR0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WHxzuBvVmjlhS7muROJN788EPpyGYvpJaJwr5gFxaspAVUvSKPGLOWzpp+thIfVy7 vZlPKv1zlrIJKTubStjukqCQgAdYQ/TvzalS+kp4+V1kqmrvYq9lX5XxzLI1wgUD85 bIzkOJheCsL8Sa8ZRuEZ4/0FyOJDxaXw9ytAeaetyt4P1ettWaChS8RnO7m+0nJL0k nUmjZYdPqNfi3ji5ZMjAkuWI/Y2PXF143kIFHBvQZbLHNMl0Pl+QCmnGAKhpMwmSLO 0jmXYCEJTFeQtl+YB/SW6fCds30U5hDtltQtxUg7qfX2Pv9irrrSLGqcUhEdRFeIat zBm9OYrmKSfKA== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 89B741209CD; Wed, 14 Sep 2022 10:27:38 -0400 (EDT) In-Reply-To: <878rmmb0np.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 14 Sep 2022 14:28:26 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242467 Archived-At: >> The change I introduced tried to preserve as much of the existing >> completion as possible, by only using the non-fallback pcomplete >> rules and keeping the existing `shell-filename-completion` and >> `comint-filename-completion` thingies as the fallback. >> >> I don't know that it's the best choice. It was just the >> conservative choice. > > Could just put an additional function at the end of the list there > that does what pcomplete-completions-at-point does when > pcomplete-default-completion-function isn't set to #'ignore? Could be. Tho it feels like adding yet another hack upon more hacks just because we don't know what the other code does. [ Which is exactly what I did as well when I set `pcomplete-default-completion-function` to `ignore`. ] I wish someone could take the time to try and understand what `shell-filename-completion` and `comint-filename-completion` do there really (I mean, I understand what they're supposed to do, but I don't understand why they're both there), how they compare to what `pcomplete-default-completion-function` does by default (which should be very similar), and then fix bug#51130 The Right Way. Stefan