From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#57929: 29.0.50; package-quickstart.elc incompatible with Emacs 28.2 due to defvar-1 Date: Mon, 19 Sep 2022 08:38:55 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31012"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57929@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 19 14:48:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaGCJ-0007sO-MI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 14:48:27 +0200 Original-Received: from localhost ([::1]:49068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaGCI-0000Tb-Dj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 08:48:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaG4A-0002xH-7e for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 08:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaG49-00075o-V3 for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 08:40:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oaG49-00059w-LW for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 08:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 12:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57929 X-GNU-PR-Package: emacs Original-Received: via spool by 57929-submit@debbugs.gnu.org id=B57929.166359114919764 (code B ref 57929); Mon, 19 Sep 2022 12:40:01 +0000 Original-Received: (at 57929) by debbugs.gnu.org; 19 Sep 2022 12:39:09 +0000 Original-Received: from localhost ([127.0.0.1]:52642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaG3J-00058h-HN for submit@debbugs.gnu.org; Mon, 19 Sep 2022 08:39:09 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaG3E-000587-Gm for 57929@debbugs.gnu.org; Mon, 19 Sep 2022 08:39:07 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AA0A64409A5; Mon, 19 Sep 2022 08:38:58 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 626544409DD; Mon, 19 Sep 2022 08:38:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1663591137; bh=mZKIywliNP80GPdFRw9nK03JQs1knEKGOOhpOAA/n2c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BcB9IOk6Fa0/tGym5HyN6tYoteWSbL9x7I6fLLU+C39LjS5BWdaWLaWEKtGehivR5 GpxMGPVmqR1oWl8a5AG+0r7XDBa/VJU1zu1e+5zVA9LB5620u+TVPWfLH7ED+M2GS4 1mbi1fU6a2ByVtz8ONSwMf4nItGWDj5IXP1nyKuIInl6rph4wJDFe9DO1yDkd7Fqai sWiNrnfa6n4VkcPDeev0fHCPXNufk5rJfTRVFQYXxYqPGqliSSE5Dwo7rFF4Im9YEf kgwsYIT3a+sRwxpQyT6tFF/+T28F+AkzNoym40fu8aO3izq2hPslj+kfBuBXDRRPV5 29jx0kMo0+hgw== Original-Received: from pastel (unknown [157.52.9.190]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3DEF1120B1C; Mon, 19 Sep 2022 08:38:57 -0400 (EDT) In-Reply-To: (Stefan Kangas's message of "Mon, 19 Sep 2022 05:56:39 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243078 Archived-At: Stefan Kangas [2022-09-19 05:56:39] wrote: > It seems like the package-quickstart.elc is now backwards-incompatible > since defvar-1 is missing. Yes, same old issue of compatibility for `.elc` files. It would be good to improve our handling of such situations (for `package-quickstart.elc` as well as for other compiled files such as those in ELPA packages). I can think of two ways to detect the problem: - When loading the `.elc` file signals an error. [ It might be a legitimate error, but we could catch it and ask the user if we should try loading the non-compiled file instead. ] - When the loaded file's version marker is "too large". The 4th byte of `.elc` files holds the major version of the Emacs that compiled it (except that 29.0.xx counts as 28, see comment in bytecomp.el:2390), so we could easily use this evidence that the file was compiled by a newer Emacs to skip the .`elc` file. Once detected we could also delete the file, or recompile it, or suggest doing one of those. Deleting could throw away a handy file. And recompiling may generate an invalid `.elc` file if some of the dependencies defining macros aren't loaded (or may fail if some of the required dependencies aren't in `load-path`). Stefan