From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 53371@debbugs.gnu.org, mail@daniel-mendler.de
Subject: bug#53371: 28.0.90; eshell completion error when trying to complete buffer name, args-out-of-range
Date: Fri, 24 Feb 2023 10:09:02 -0500 [thread overview]
Message-ID: <jwvzg933y70.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <9306144c-afbd-efcd-a90b-f22c32753a72@gmail.com> (Jim Porter's message of "Thu, 23 Feb 2023 22:40:09 -0800")
> + (let ((buffer-p (if (match-beginning 1)
> + (equal (match-string 1) "buffer")
> t)) ;; buffer-p is non-nil by default.
The comment just describes what the code does but it would be more
useful to explain why.
Stefan
next prev parent reply other threads:[~2023-02-24 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 17:35 bug#53371: 28.0.90; eshell completion error when trying to complete buffer name, args-out-of-range Daniel Mendler
2023-02-02 6:40 ` Jim Porter
2023-02-24 6:40 ` Jim Porter
2023-02-24 15:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-02-24 17:53 ` Jim Porter
2023-03-12 3:35 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzg933y70.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=53371@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).