From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65726: 29.1.50; Crash in regexp engine Date: Sat, 16 Sep 2023 11:48:02 -0400 Message-ID: References: <8e1b4e50-0430-3eb3-e486-60def1e4821f@gmx.at> <83fs3u5e7u.fsf@gnu.org> <835y4q5apw.fsf@gnu.org> <776370AB-662F-4C0A-95BF-97DEA4F18F54@gmail.com> <3A0AC9E2-A420-47B6-870A-69C53FCAEF71@gmail.com> <65105BCA-1884-4673-A8F8-03E3C7ABAAEA@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38282"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: martin rudalics , Eli Zaretskii , 65726@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 16 17:49:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qhXXm-0009jw-J3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Sep 2023 17:49:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhXXV-0000wb-Ld; Sat, 16 Sep 2023 11:48:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhXXT-0000w8-Q6 for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 11:48:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhXXT-0005EP-HY for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 11:48:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhXXa-0001w6-J3 for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 11:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Sep 2023 15:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65726 X-GNU-PR-Package: emacs Original-Received: via spool by 65726-submit@debbugs.gnu.org id=B65726.16948792997228 (code B ref 65726); Sat, 16 Sep 2023 15:49:02 +0000 Original-Received: (at 65726) by debbugs.gnu.org; 16 Sep 2023 15:48:19 +0000 Original-Received: from localhost ([127.0.0.1]:48320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhXWt-0001sU-2S for submit@debbugs.gnu.org; Sat, 16 Sep 2023 11:48:19 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhXWr-0001ri-9s for 65726@debbugs.gnu.org; Sat, 16 Sep 2023 11:48:18 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C84888075E; Sat, 16 Sep 2023 11:48:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694879283; bh=nYNHK/LtSJodWEREH3U/PS/ZBBNjCFTYOUygk8dWRTY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=W+hcOXVq5x4YeJcEy2HWblYTyiOGMQ75undMdmsD1EuCyurLhaBmX2se0Bgqin0QT 7vwYfU504SKDaHYq0GLNWoswpC5eJUA8y5m3OSl7n+o2zNBEffrWHgOuofLOIVOe+9 ozl11WYxBhf9VDs3LklRB7lCno1us5cwEh4vug0yijgchFNKvPkY9F2JizBLVVa8cy lSmoKA4rE6Sq864in1WpPLZl3z5Uz8wUwcS6F4zCipaeO8FrGKwk/qivDa4zJOGSJs Gj41p0tUNlheFktoXHOXs1xL5cWXr8LJqiW134FHPD2Uy3Eez7fHx6rP7CHXRkb/Jb q5+jafme72rIw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7FCA8803EB; Sat, 16 Sep 2023 11:48:03 -0400 (EDT) Original-Received: from pastel (unknown [104.247.237.102]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2BD111201D0; Sat, 16 Sep 2023 11:48:03 -0400 (EDT) In-Reply-To: <65105BCA-1884-4673-A8F8-03E3C7ABAAEA@gmail.com> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Sat, 16 Sep 2023 12:49:58 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270628 Archived-At: > I think you are right, but wouldn't mind seeing it confirmed > empirically. Say, by cross-checking using an an alternative (slower) > implementation that directly checks whether a node has been visited before. I'm reworking my code so it takes 2 arguments: the loop-entry and the loop-exit. Any jump outside of those bounds should never happen so we can assert it to check that our assumptions are right (and we can return false when we don't compile assertions, so it's never over-optimistic). Stefan