From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66928: [PATCH 2/2] Update names to match the docstring Date: Sat, 04 Nov 2023 12:13:05 -0400 Message-ID: References: <87cywpwuid.fsf@jeremybryant.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10886"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 66928@debbugs.gnu.org To: Jeremy Bryant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 04 17:13:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzJHU-0002el-8e for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Nov 2023 17:13:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzJH7-0006Hs-7h; Sat, 04 Nov 2023 12:13:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzJH5-0006HP-9c for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 12:13:27 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzJH4-0002Lc-FX for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 12:13:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzJHe-0007EE-JS for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 12:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Nov 2023 16:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66928-submit@debbugs.gnu.org id=B66928.169911443727766 (code B ref 66928); Sat, 04 Nov 2023 16:14:02 +0000 Original-Received: (at 66928) by debbugs.gnu.org; 4 Nov 2023 16:13:57 +0000 Original-Received: from localhost ([127.0.0.1]:35663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzJHZ-0007Dm-3v for submit@debbugs.gnu.org; Sat, 04 Nov 2023 12:13:57 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzJHW-0007DV-9o for 66928@debbugs.gnu.org; Sat, 04 Nov 2023 12:13:55 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 271A1440F8C; Sat, 4 Nov 2023 12:13:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1699114387; bh=C0/kms0tY1049UdxTpfN+d8O5kkKaIKC0sD/UgL3Iwo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bwWC/9nOFEgyqbWBWH2qRLvK1O2XAXK9vo99FK8Q9zxd/Ner9ytfyleoU3FK/2CTS I/gj8FEhsPB38SFehTcfkZ+orFkH6176LXOjurIvrdrwAHHJfUyz/QuUpJcjNTnxn/ PvSMGhznCoAVNoMeAzPrt/CEnbWSOt9UYXl2SJdYbJyyOrTJFn2JwW2OM/eozLJ3Mx 3W8vx0VcSs/tspb0TTzjrjrIJYbkYeG22ANTpxjL1QI+39j4RJBjUwO79E+FF4/UFv FDJjThrDwwrYzlsFSXyOpHTBXFrLvFZdkf3A3/XmR1yRYG6CR+zoyJAl6bJHTj4Jtb D8AeOImAXk+ig== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F0BA0440FC2; Sat, 4 Nov 2023 12:13:06 -0400 (EDT) Original-Received: from pastel (unknown [45.72.195.71]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CB4201201B6; Sat, 4 Nov 2023 12:13:06 -0400 (EDT) In-Reply-To: <87cywpwuid.fsf@jeremybryant.net> (Jeremy Bryant's message of "Sat, 04 Nov 2023 12:49:27 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273784 Archived-At: > I noticed that for the function below the docstring doesn't match the > arg names. I agree it's an odd choice (requiring the use of `\n(fn SYMBOL PROPNAME)`), but it's not a big problem since the (fn SYMBOL PROPNAME) makes sure that the right names are presented in `C-h o`. If you want to install a patch like you suggest, then please remove the (fn SYMBOL PROPNAME) since it makes it redundant. It'd be considered as a cosmetic patch. One more thing: the first line of the commit should be a bit more specific, e.g. it could start with "(cl-remprop):" Stefan