bug#1458: 23.0.60; mouse-posn-property: Args out of range

bug#1458: 23.0.60; mouse-posn-property: Args out of range

[Stephen Berman]

1. emacs -Q

2. Eval this:

   (defun testme ()
     (save-selected-window
       (switch-to-buffer "testme")))

If `testme' is not a fresh buffer, see observation (a) below.

3. Eval (run-at-time 3 nil 'testme) and wait 3 seconds.

4. When the `testme' buffer appears, move the mouse cursor over the mode line;
as soon as it hits a position that has a help-echo property containing the
string "mouse-2", the following error is raised:

   mouse-posn-property: Args out of range: 719

The out of range number is (point) in step 3.

Backtrace:

Debugger entered--Lisp error: (args-out-of-range 719)
  get-char-property(719 follow-link #<window 220 on testme>)
  mouse-posn-property((#<window 220 on testme> mode-line (467 . 644) 0 (#("-%-" 0 3 ...) . 2) 719 (58 . 46) nil (2 . 4) (8 . 16)) follow-link)
  (or (mouse-posn-property pos (quote follow-link)) (key-binding [follow-link] nil t pos))
  (and (or (not ...) mouse-1-click-in-non-selected-windows (eq ... ...)) (or (mouse-posn-property pos ...) (key-binding [follow-link] nil t pos)))
  (let ((action ...)) (cond (... ...) (... ...) (t action)))
  mouse-on-link-p((#<window 220 on testme> mode-line (467 . 644) 0 (#("-%-" 0 3 ...) . 2) 719 (58 . 46) nil (2 . 4) (8 . 16)))
  mouse-fixup-help-message("mouse-1: Select (drag to resize)\nmouse-2: Make current window occupy the whole frame\nmouse-3: Remove current window from display")


Observations:

a. The error only occurs when (point) of the the buffer that is current when
   step 3 is carried out, is greater than (point-max) of the buffer `testme'.
b. The error only occurs when testme is called from a timer.
c. The error only occurs when the function called from the timer
   contains a call to save-selected-window.
d. The error only occurs with propertized text satisfying mouse-on-link-p in
   either the mode line or the header line, i.e., suitably propertized
   text inserted into the editing area of the buffer does not induce the
   error.


In GNU Emacs 23.0.60.17 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-11-29 on escher
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

bug#1458: marked as done (23.0.60; mouse-posn-property: Args out of range)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]


Your message dated Sun, 30 Nov 2008 12:36:36 -0500
with message-id <87k5alru8r.fsf@cyd.mit.edu>
and subject line Re: 23.0.60; mouse-posn-property: Args out of range
has caused the Emacs bug report #1458,
regarding 23.0.60; mouse-posn-property: Args out of range
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1458: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1458
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4621 bytes --]

From: Stephen Berman <stephen.berman@gmx.net>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; mouse-posn-property: Args out of range
Date: Sat, 29 Nov 2008 21:31:10 +0100
Message-ID: <874p1qgtpt.fsf@escher.local.home>

1. emacs -Q

2. Eval this:

   (defun testme ()
     (save-selected-window
       (switch-to-buffer "testme")))

If `testme' is not a fresh buffer, see observation (a) below.

3. Eval (run-at-time 3 nil 'testme) and wait 3 seconds.

4. When the `testme' buffer appears, move the mouse cursor over the mode line;
as soon as it hits a position that has a help-echo property containing the
string "mouse-2", the following error is raised:

   mouse-posn-property: Args out of range: 719

The out of range number is (point) in step 3.

Backtrace:

Debugger entered--Lisp error: (args-out-of-range 719)
  get-char-property(719 follow-link #<window 220 on testme>)
  mouse-posn-property((#<window 220 on testme> mode-line (467 . 644) 0 (#("-%-" 0 3 ...) . 2) 719 (58 . 46) nil (2 . 4) (8 . 16)) follow-link)
  (or (mouse-posn-property pos (quote follow-link)) (key-binding [follow-link] nil t pos))
  (and (or (not ...) mouse-1-click-in-non-selected-windows (eq ... ...)) (or (mouse-posn-property pos ...) (key-binding [follow-link] nil t pos)))
  (let ((action ...)) (cond (... ...) (... ...) (t action)))
  mouse-on-link-p((#<window 220 on testme> mode-line (467 . 644) 0 (#("-%-" 0 3 ...) . 2) 719 (58 . 46) nil (2 . 4) (8 . 16)))
  mouse-fixup-help-message("mouse-1: Select (drag to resize)\nmouse-2: Make current window occupy the whole frame\nmouse-3: Remove current window from display")


Observations:

a. The error only occurs when (point) of the the buffer that is current when
   step 3 is carried out, is greater than (point-max) of the buffer `testme'.
b. The error only occurs when testme is called from a timer.
c. The error only occurs when the function called from the timer
   contains a call to save-selected-window.
d. The error only occurs with propertized text satisfying mouse-on-link-p in
   either the mode line or the header line, i.e., suitably propertized
   text inserted into the editing area of the buffer does not induce the
   error.


In GNU Emacs 23.0.60.17 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-11-29 on escher
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t



[-- Attachment #3: Type: message/rfc822, Size: 1439 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 1458-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; mouse-posn-property: Args out of range
Date: Sun, 30 Nov 2008 12:36:36 -0500
Message-ID: <87k5alru8r.fsf@cyd.mit.edu>

> 1. emacs -Q
>
> 2. Eval this:
>
>    (defun testme ()
>      (save-selected-window
>        (switch-to-buffer "testme")))
>
> 3. Eval (run-at-time 3 nil 'testme) and wait 3 seconds.
>
> 4. When the `testme' buffer appears, move the mouse cursor over the
> mode line; as soon as it hits a position that has a help-echo property
> containing the string "mouse-2", the following error is raised:
>
>    mouse-posn-property: Args out of range: 719

I've checked in a fix.  Thanks.

bug#1458: 23.0.60; mouse-posn-property: Args out of range

[Stefan Monnier]

You patch to timer_check doesn't seem right: it may cause the
current-buffer to be changed even if the timer doesn't do anything, just
because the current-buffer before running the timer wasn't the
selected-window's buffer.  It causes no end of trouble in Gnus
(e.g. when connecting to an IMAP server, it calls read-passwd during
which calls to read-event can run timers, so we start read-passwd in
the IMAP process's buffer and we finish it in the *Group* buffer or
which ever buffer is currently displayed, after which
send-process-string fails because it can't find the process).


        Stefan

bug#1458: 23.0.60; mouse-posn-property: Args out of range

[Chong Yidong]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> You patch to timer_check doesn't seem right: it may cause the
> current-buffer to be changed even if the timer doesn't do anything, just
> because the current-buffer before running the timer wasn't the
> selected-window's buffer.  It causes no end of trouble in Gnus
> (e.g. when connecting to an IMAP server, it calls read-passwd during
> which calls to read-event can run timers, so we start read-passwd in
> the IMAP process's buffer and we finish it in the *Group* buffer or
> which ever buffer is currently displayed, after which
> send-process-string fails because it can't find the process).

I see.  The change is reverted.

Now I'm not certain how to deal with the problem described in bug#1458.
Perhaps we should make the selected window's buffer current only if the
selected window's buffer was current before running the timer.  WDYT?

bug#1458: 23.0.60; mouse-posn-property: Args out of range

[Stefan Monnier]

>> You patch to timer_check doesn't seem right: it may cause the
>> current-buffer to be changed even if the timer doesn't do anything, just
>> because the current-buffer before running the timer wasn't the
>> selected-window's buffer.  It causes no end of trouble in Gnus
>> (e.g. when connecting to an IMAP server, it calls read-passwd during
>> which calls to read-event can run timers, so we start read-passwd in
>> the IMAP process's buffer and we finish it in the *Group* buffer or
>> which ever buffer is currently displayed, after which
>> send-process-string fails because it can't find the process).

> I see.  The change is reverted.

> Now I'm not certain how to deal with the problem described in bug#1458.
> Perhaps we should make the selected window's buffer current only if the
> selected window's buffer was current before running the timer.  WDYT?

I don't think so.  I think we need to track this bug further down.
Maybe the problem is that some code uses current_buffer (maybe to build
the mouse events?) rather than selected_window->buffer.


        Stefan

bug#1458: marked as done (23.0.60; mouse-posn-property: Args out of range)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]


Your message dated Tue, 02 Dec 2008 18:13:44 -0500
with message-id <87zlje41cn.fsf@cyd.mit.edu>
and subject line Re: bug#1458: 23.0.60; mouse-posn-property: Args out of range
has caused the Emacs bug report #1458,
regarding 23.0.60; mouse-posn-property: Args out of range
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1458: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1458
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4621 bytes --]

From: Stephen Berman <stephen.berman@gmx.net>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; mouse-posn-property: Args out of range
Date: Sat, 29 Nov 2008 21:31:10 +0100
Message-ID: <874p1qgtpt.fsf@escher.local.home>

1. emacs -Q

2. Eval this:

   (defun testme ()
     (save-selected-window
       (switch-to-buffer "testme")))

If `testme' is not a fresh buffer, see observation (a) below.

3. Eval (run-at-time 3 nil 'testme) and wait 3 seconds.

4. When the `testme' buffer appears, move the mouse cursor over the mode line;
as soon as it hits a position that has a help-echo property containing the
string "mouse-2", the following error is raised:

   mouse-posn-property: Args out of range: 719

The out of range number is (point) in step 3.

Backtrace:

Debugger entered--Lisp error: (args-out-of-range 719)
  get-char-property(719 follow-link #<window 220 on testme>)
  mouse-posn-property((#<window 220 on testme> mode-line (467 . 644) 0 (#("-%-" 0 3 ...) . 2) 719 (58 . 46) nil (2 . 4) (8 . 16)) follow-link)
  (or (mouse-posn-property pos (quote follow-link)) (key-binding [follow-link] nil t pos))
  (and (or (not ...) mouse-1-click-in-non-selected-windows (eq ... ...)) (or (mouse-posn-property pos ...) (key-binding [follow-link] nil t pos)))
  (let ((action ...)) (cond (... ...) (... ...) (t action)))
  mouse-on-link-p((#<window 220 on testme> mode-line (467 . 644) 0 (#("-%-" 0 3 ...) . 2) 719 (58 . 46) nil (2 . 4) (8 . 16)))
  mouse-fixup-help-message("mouse-1: Select (drag to resize)\nmouse-2: Make current window occupy the whole frame\nmouse-3: Remove current window from display")


Observations:

a. The error only occurs when (point) of the the buffer that is current when
   step 3 is carried out, is greater than (point-max) of the buffer `testme'.
b. The error only occurs when testme is called from a timer.
c. The error only occurs when the function called from the timer
   contains a call to save-selected-window.
d. The error only occurs with propertized text satisfying mouse-on-link-p in
   either the mode line or the header line, i.e., suitably propertized
   text inserted into the editing area of the buffer does not induce the
   error.


In GNU Emacs 23.0.60.17 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-11-29 on escher
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t



[-- Attachment #3: Type: message/rfc822, Size: 1654 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 1458-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1458: 23.0.60; mouse-posn-property: Args out of range
Date: Tue, 02 Dec 2008 18:13:44 -0500
Message-ID: <87zlje41cn.fsf@cyd.mit.edu>

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> I think we need to track this bug further down.  Maybe the problem is
> that some code uses current_buffer (maybe to build the mouse events?)
> rather than selected_window->buffer.

I've made a change to make_lispy_position that should solve this.