From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: "Štěpán Němec" <stepnem@gmail.com>
Cc: 6716@debbugs.gnu.org
Subject: bug#6716: 23.2; Setting `find-function-source-path' has no effect.
Date: Mon, 26 Jul 2010 01:45:13 +0200 [thread overview]
Message-ID: <jwvy6czceoq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <874ofpqeiu.fsf@gmail.com> ("Štěpán Němec"'s message of "Sat, 24 Jul 2010 13:56:41 +0200")
> Because `find-library-name' receives as its LIBRARY argument the full
> path, but doesn't strip the directory part, setting
> `find-function-source-path' has no effect on symbol finding -- Emacs
> still tries the path guessed according to load path (which is not
> correct in case you have the Elisp sources in directory different from
> the compiled files).
The file name has been changed to a full absolute name to avoid showing
the wrong file when there's some shadowing going on. So your patch
would re-introduce this problem.
Also, it may not work for files that were loaded as "foo/bar". I think
the load-history needs to be changed to keep track of both the absolute
file name and the name used to load the file
(i.e. "/bla/bla/foo/bar.elc" and "foo/bar"). Then in
find-function-source-path we will first try for /bla/bla/foo/bar.el and
when that fails we can fall back on searching for foo/bar.el.
Stefan
> This simple change seems to fix it for me:
> diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el
> index 216d91b..f704c63 100644
> --- a/lisp/emacs-lisp/find-func.el
> +++ b/lisp/emacs-lisp/find-func.el
> @@ -150,10 +150,10 @@ (defun find-library-name (library)
> (if (string-match "\\.el\\(c\\(\\..*\\)?\\)\\'" library)
> (setq library (replace-match "" t t library)))
> (or
> - (locate-file library
> + (locate-file (file-name-nondirectory library)
> (or find-function-source-path load-path)
> (find-library-suffixes))
> - (locate-file library
> + (locate-file (file-name-nondirectory library)
> (or find-function-source-path load-path)
> load-file-rep-suffixes)
> (error "Can't find library %s" library)))
> Regards,
> Štěpán
next prev parent reply other threads:[~2010-07-25 23:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-24 11:56 bug#6716: 23.2; Setting `find-function-source-path' has no effect Štěpán Němec
2010-07-25 23:45 ` Stefan Monnier [this message]
2010-07-26 4:17 ` Štěpán Němec
2010-07-26 4:51 ` Štěpán Němec
2010-07-26 10:23 ` Stefan Monnier
2010-07-26 11:20 ` Štěpán Němec
2010-07-26 21:44 ` Stefan Monnier
2010-07-27 10:07 ` Štěpán Němec
2010-07-27 11:57 ` Stefan Monnier
2010-07-26 21:40 ` MON KEY
2010-07-27 9:39 ` Štěpán Němec
2010-07-28 1:38 ` MON KEY
2022-02-13 10:02 ` Lars Ingebrigtsen
2022-02-15 14:50 ` Štěpán Němec
2022-02-17 11:33 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy6czceoq.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=6716@debbugs.gnu.org \
--cc=stepnem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).