From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#6999: 23.2; [PATCH] appt ignores included diary files Date: Wed, 08 Sep 2010 16:38:42 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1283958040 24912 80.91.229.12 (8 Sep 2010 15:00:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 8 Sep 2010 15:00:40 +0000 (UTC) Cc: 6999@debbugs.gnu.org To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 08 17:00:39 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OtM8Y-0001Mq-C1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Sep 2010 17:00:35 +0200 Original-Received: from localhost ([127.0.0.1]:41709 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OtM8S-00050w-RN for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Sep 2010 11:00:28 -0400 Original-Received: from [140.186.70.92] (port=33162 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OtLor-0000rC-MU for bug-gnu-emacs@gnu.org; Wed, 08 Sep 2010 10:40:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OtLoo-0002LX-3y for bug-gnu-emacs@gnu.org; Wed, 08 Sep 2010 10:40:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43196) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OtLoo-0002LQ-1S for bug-gnu-emacs@gnu.org; Wed, 08 Sep 2010 10:40:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OtLlm-00037h-GX; Wed, 08 Sep 2010 10:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Sep 2010 14:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6999 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6999-submit@debbugs.gnu.org id=B6999.128395660811997 (code B ref 6999); Wed, 08 Sep 2010 14:37:02 +0000 Original-Received: (at 6999) by debbugs.gnu.org; 8 Sep 2010 14:36:48 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OtLlX-00037S-P8 for submit@debbugs.gnu.org; Wed, 08 Sep 2010 10:36:47 -0400 Original-Received: from impaqm3.telefonica.net ([213.4.138.3]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OtLlV-00037M-8S for 6999@debbugs.gnu.org; Wed, 08 Sep 2010 10:36:46 -0400 Original-Received: from IMPmailhost3.adm.correo ([10.20.102.124]) by IMPaqm3.telefonica.net with bizsmtp id 46GM1f00B2h2L9m3PEejM4; Wed, 08 Sep 2010 16:38:43 +0200 Original-Received: from ceviche.home ([83.61.36.43]) by IMPmailhost3.adm.correo with BIZ IMP id 4Eei1f00R0vquEj1jEejtt; Wed, 08 Sep 2010 16:38:43 +0200 X-Brightmail-Tracker: AAAAAA== X-TE-authinfo: authemail="monnier$movistar.es" |auth_email="monnier@movistar.es" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" Original-Received: by ceviche.home (Postfix, from userid 20848) id B4246660D2; Wed, 8 Sep 2010 16:38:42 +0200 (CEST) In-Reply-To: (Leo's message of "Wed, 08 Sep 2010 13:45:46 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 08 Sep 2010 10:37:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40039 Archived-At: > Annoyingly appt-check pops up the main diary buffer. So maybe do this > instead: [...] > - (appt-check t))) > + (save-window-excursion (appt-check t)))) Not good enough: the buffer might have popped up in a new frame, in which case save-window-excursion won't be of any help. Basically, you can't undo a "pop up a buffer", so the code should be written in such a way that it's only done when it's *really* necessary. Stefan