unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Kifer <kifer@cs.stonybrook.edu>,
	Stefano Zacchiroli <zack@upsilon.cc>
Cc: 9146@debbugs.gnu.org
Subject: bug#9146: M-x broken in console mode with viper (always gives: "viper bell"))
Date: Fri, 04 Nov 2011 18:43:44 -0400	[thread overview]
Message-ID: <jwvy5vva56l.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20110928072531.GA12901@upsilon.cc> (Stefano Zacchiroli's message of "Wed, 28 Sep 2011 09:25:31 +0200")

OK I can reproduce your problem and have tracked it down to a change of
mine in the keymap.c code.

The problem is that viper-intercept-ESC-key relies on a quirk of
the function key-binding which I fixed in Emacs-24.

More specifically, in Emacs-23, the following happened:

   (local-set-key "\e" 'toto)
   (key-binding "\ex")  =>  execute-extended-command

I.e. key-binding returned a binding that is not actually valid because
it's hidden by a shorter key-sequence in a keymap of higher precedence.
This has been fixed in Emacs-24 where it now returns nil in this case.

In the case of viper-intercept-ESC-key, the problematic keybinding is
not in the local-map but in a minor-mode-map installed by Viper and the
command is (of course) viper-intercept-ESC-key, but the problem is
the same.

IOW viper-intercept-ESC-key needs to be changed to call key-binding in
a context where Viper's minor-mode map(s) have been temporarily disabled
so the ESC binding to viper-intercept-ESC-key doesn't hide the thing
we're looking for.


        Stefan





  parent reply	other threads:[~2011-11-04 22:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22 10:45 bug#9146: 24.0.50; M-x broken in console mode with viper (always gives: "viper bell") Stefano Zacchiroli
     [not found] ` <handler.9146.B.131133154717743.ack@debbugs.gnu.org>
2011-09-28  7:25   ` bug#9146: Acknowledgement (24.0.50; M-x broken in console mode with viper (always gives: "viper bell")) Stefano Zacchiroli
2011-09-28 16:44     ` bug#9146: 24.0.50; M-x broken in console mode with viper (always gives: "viper bell") Glenn Morris
2011-09-28 16:48       ` Glenn Morris
2011-09-30  8:50         ` Stefano Zacchiroli
2011-09-30  9:14           ` Julien Danjou
2011-11-04 22:43     ` Stefan Monnier [this message]
2012-02-27 10:12       ` bug#9146: M-x broken in console mode with viper (always gives: "viper bell")) Chong Yidong
2012-02-27 12:08         ` Stefano Zacchiroli
2012-02-27 13:14           ` Chong Yidong
2012-02-27 14:17             ` Stefano Zacchiroli
2012-02-28  1:32         ` Michael Kifer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvy5vva56l.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=9146@debbugs.gnu.org \
    --cc=kifer@cs.stonybrook.edu \
    --cc=zack@upsilon.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).